Repository navigation
feat: print err.cause if exists - #91
Merged
Merged
Conversation
fengmk2
reviewed
Aug 30, 2023
|
|
||
| const errProperties = Object.keys(err).map(key => inspect(key, err[key])).join('\n'); | ||
| return util.format('nodejs.%s: %s\n%s\n%s\npid: %s\nhostname: %s\n', | ||
| if (err.cause) { |
Member
There was a problem hiding this comment.
我以为 err.stack 就会自动打算 cause 的堆栈？
fengmk2
approved these changes
Aug 30, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 98.69% 98.72% +0.03%
==========================================
Files 14 14
Lines 1307 1338 +31
Branches 215 222 +7
==========================================
+ Hits 1290 1321 +31
Misses 17 17
☔ View full report in Codecov by Sentry. |
fengmk2
pushed a commit
that referenced
this pull request
Sep 5, 2023
[skip ci] ## [3.4.0](v3.3.1...v3.4.0) (2023-09-05) ### Features * print err.cause if exists ([#91](#91)) ([a054bca](a054bca))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change