Skip to content

feat: allow custom format paddingMessage - #83

Merged
fengmk2 merged 2 commits into
masterfrom
formatter-missing-paddingMessage
Jan 12, 2023
Merged

fengmk2 merged 2 commits into
masterfrom
formatter-missing-paddingMessage

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jan 11, 2023

Copy link
Copy Markdown
Member

and fixed paddingMessage missing on contextFormatter(meta)

… ctx

and fixed paddingMessage missing on contextFormatter(meta)
@codecov

codecov Bot commented Jan 11, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 98.67% // Head: 98.69% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9390f3b) compared to base (977cc96).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   98.67%   98.69%   +0.01%     
==========================================
  Files          14       14              
  Lines        1285     1300      +15     
  Branches      209      214       +5     
==========================================
+ Hits         1268     1283      +15     
  Misses         17       17              
Impacted Files Coverage Δ
lib/egg/logger.js 100.00% <100.00%> (ø)
lib/logger.js 100.00% <100.00%> (ø)
lib/transports/transport.js 100.00% <100.00%> (ø)
lib/utils.js 94.44% <100.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread package.json
"dependencies": {
"chalk": "^4.1.2",
"circular-json-for-egg": "^1.0.0",
"debug": "^4.3.4",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无依赖

@fengmk2
fengmk2 merged commit 2ac591a into master Jan 12, 2023
@fengmk2
fengmk2 deleted the formatter-missing-paddingMessage branch January 12, 2023 01:31
atian25 pushed a commit that referenced this pull request Jan 12, 2023
[skip ci]

## [3.1.0](v3.0.1...v3.1.0) (2023-01-12)

### Features

* allow custom format paddingMessage ([#83](#83)) ([2ac591a](2ac591a))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Comment thread lib/egg/logger.js
level: this.options.consoleLevel,
formatter: utils.consoleFormatter,
contextFormatter: this.options.contextFormatter,
formatPaddingMessage: this.options.formatPaddingMessage,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请问,这里是不是写错了?应该跟49行一样?

paddingMessageFormatter: this.options.paddingMessageFormatter

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来是的,来个 pr 修复一下?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

帮忙加一下权限?我本地建了一个分支修复了,但是push不到远端,也就发不了PR了

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先 fork,push 到你的 repo,然后就可以提交 pull request 了。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢,搞定了。PR #92 已发。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants