Open
Conversation
- Refactor keyval to use a flattened $state store. - Fix instance.ts variant logic for leave events. - Fix timeout in game.test.ts. - Improve instance.test.ts coverage.
…ee demo - Core: Added ref.self and ref.tag to core-experimental. - Core: Implemented internal dependency resolution and array facet multiplexing in instance.ts. - Core: Improved resource cleanup in instance.ts for custom logic. - App: Implemented polymorphic Chat User demo with union and keyval. - App: Implemented advanced Recursive Tree Demo with single-selection, targeted collapsing, and reactive renaming. - Docs: Added DEMO_RD.md and DEMO_IMPL.md for the tree demo. - Tests: Added comprehensive coverage for recursion and tag resolution.
There was a problem hiding this comment.
Copilot reviewed 72 out of 75 changed files in this pull request and generated 22 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Enable linting and size-limit checks in GitHub Actions - Fix size-limit executor compatibility with v11 - Remove obsolete lint:workspace script for Nx 19 - Verify build, test, and type-check pass locally
doasync
force-pushed
the
research/models
branch
from
0934518 to
d151541
Compare
doasync
force-pushed
the
research/models
branch
from
d151541 to
7571ba6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 143 out of 228 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
doasync
force-pushed
the
research/models
branch
from
cb4dc2c to
7571ba6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Model API & Fast Food Demo App
Branch:
research/models->main🏗 Structure Changes
New experimental packages and demonstration applications.
New Packages & Apps
packages/core-experimental: A new core library introducing the "Model + Facets" architecture. It provides primitives likefacet(),define,model(), andkeyval()for building composable domain models.apps/fast-food: A comprehensive proof-of-concept application built withcore-experimental. It demonstrates how to handle complex domain requirements like polymorphism (heterogeneous carts) and reusable logic (traits).apps/models-research: A dedicated workspace for research documentation (PAPER.md), presentations, and isolated demos (GameDemo,UserDemo) to validate the new architectural concepts.Modified Packages
packages/core: Internal updates to definitions and factory paths to support the experimental extensions.packages/react: Added sanity tests and example integrations to ensure compatibility with the new model structure.This PR introduces the new architecture.