Skip to content

fix(dtls): remove duplicate DEL_PEER in handle_alert() #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
re2zero wants to merge 1 commit into from
Closed

fix(dtls): remove duplicate DEL_PEER in handle_alert() #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dtls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4502,10 +4502,9 @@ handle_alert(dtls_context_t *ctx, dtls_peer_t *peer,
dtls_info("** Alert: level %d, description %d\n", data[0], data[1]);

/* The peer object is invalidated for FATAL alerts and close
* notifies. This is done in two steps.: First, remove the object
* from our list of peers. After that, the event handler callback is
* invoked with the still existing peer object. Finally, the storage
* used by peer is released.
* notifies. The event handler callback is invoked with the peer
* object, then dtls_destroy_peer() removes the peer from the
* hash table and releases the storage.
*/
close_notify = data[1] == DTLS_ALERT_CLOSE_NOTIFY;
if (data[0] == DTLS_ALERT_LEVEL_FATAL || close_notify) {
Expand All @@ -4514,8 +4513,6 @@ handle_alert(dtls_context_t *ctx, dtls_peer_t *peer,
else
dtls_alert("%d invalidate peer\n", data[1]);

DEL_PEER(ctx->peers, peer);

#ifdef WITH_CONTIKI
#ifndef NDEBUG
PRINTF("removed peer [");
Expand Down