Skip to content

Add skeleton for query and cancel action#1397

Merged
relu91 merged 4 commits into
eclipse-thingweb:masterfrom
danielpeintner:scripting-SNAPSHOT.31
Jun 18, 2025
Merged

Add skeleton for query and cancel action#1397
relu91 merged 4 commits into
eclipse-thingweb:masterfrom
danielpeintner:scripting-SNAPSHOT.31

Conversation

@danielpeintner

@danielpeintner danielpeintner commented Jun 13, 2025

Copy link
Copy Markdown
Member

Updating "wot-typescript-definitions" to version "0.8.0-SNAPSHOT.31"

see also w3c/wot-scripting-api#561

@danielpeintner

Copy link
Copy Markdown
Member Author

Note: we have an option ignoreValidation that at the moment it is used for async actions only. Hence, we could remove that option for InteractionOutput (and keep it for ActionInteractionOutput only). However, I think we should keep it as is.

@relu91

relu91 commented Jun 13, 2025

Copy link
Copy Markdown
Member

I'm not sure whether to keep it as it was designed as an escape hatch to support async actions... Now that we have introduced a new kind of interaction output, we should implement that business logic (e.g., ignore validation) inside it.

@danielpeintner

Copy link
Copy Markdown
Member Author

I still think that having the possibility to tweak the InteractionOutput so that I can decide whether to validate data or not makes sense.
Besides async actions, we discussed other aspect such as performance and such also.

Anyhow, I don't have a very strong feeling either way. I tend to keep it as said. If you ask me to remove it, I can do it.

@relu91

relu91 commented Jun 16, 2025

Copy link
Copy Markdown
Member

We can keep it, but how do you feel about a feature that is not used anywhere in the codebase, and it might not be used in the near future, too? Isn't that a little bit confusing?

remove ignoreValidation for generic InteractionOutput
@danielpeintner

Copy link
Copy Markdown
Member Author

You have convinced me 😊

I updated the code accordingly

@relu91 relu91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@relu91
relu91 merged commit 3325e12 into eclipse-thingweb:master Jun 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants