fix: Upload correct container image#3
Merged
MaximilianSoerenPollak merged 1 commit intoJul 10, 2025
Merged
Conversation
The devcontainer/ci action uploaded the devcontainer used to develop the S-CORE devcontainer. But it should have uploaded the S-CORE devcontainer instead. According to https://github.com/devcontainers/ci/blob/main/docs/github-action.md#inputs `subFolder` should specify the correct path to the container.
opajonk
approved these changes
Jul 10, 2025
Contributor
opajonk
left a comment
opajonk
left a comment
There was a problem hiding this comment.
Yes, I think this was a mistake on my side.
MaximilianSoerenPollak
approved these changes
Jul 10, 2025
lurtz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devcontainer/ci action uploaded the devcontainer used to develop the S-CORE devcontainer. But it should have uploaded the S-CORE devcontainer instead.
According to https://github.com/devcontainers/ci/blob/main/docs/github-action.md#inputs
subFoldershould specify the correct path to the container.