Skip to content

Fix issue #15,Add Github extension#26

Merged
dcalavrezo-qorix merged 2 commits into
eclipse-score:mainfrom
Harithavaleo:main
Sep 5, 2025
Merged

Fix issue #15,Add Github extension#26
dcalavrezo-qorix merged 2 commits into
eclipse-score:mainfrom
Harithavaleo:main

Conversation

@Harithavaleo

Copy link
Copy Markdown
Contributor

added the extension github.vscode-pull-request-github

@lurtz lurtz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all which needs to be done? I was expecting it has to be configured, which is the reason I did not do it yet

@opajonk

opajonk commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Is this all which needs to be done? I was expecting it has to be configured, which is the reason I did not do it yet

You can, but I think the defaults are OK. We can change that if required.

@opajonk

opajonk commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Closes #15

@dcalavrezo-qorix dcalavrezo-qorix self-requested a review September 5, 2025 09:38
Comment on lines +77 to +78
"rust-lang.rust-analyzer",
"github.vscode-pull-request-github" // Rust language support for Visual Studio Code; see also tasks below

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rust-lang.rust-analyzer",
"github.vscode-pull-request-github" // Rust language support for Visual Studio Code; see also tasks below
"rust-lang.rust-analyzer", // Rust language support for Visual Studio Code; see also tasks below
"github.vscode-pull-request-github"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch...

Signed-off-by: Alexander Lanin <alex@lanin.de>
@dcalavrezo-qorix dcalavrezo-qorix merged commit a63a241 into eclipse-score:main Sep 5, 2025
2 of 3 checks passed
@opajonk opajonk mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants