fix(task-persistence): add cross-instance lock for concurrent task history updates (#920)#4
Closed
easonLiangWorldedtech wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUG] Concurrent task history updates from parallel tabs may cause lost entries
Problem
updateTaskHistory()has serialization within a single ClineProvider instance (seeClineProvider.taskHistory.spec.ts), but when two parallel tabs (different ClineProvider instances) callupdateTaskHistory()concurrently, there may be a race condition that causes task history entries to be overwritten or lost.Root Cause
PR Zoo-Code-Org#909 created an independent
viewLocalStatebuffer for each ClineProvider instance, but the serialization logic inupdateTaskHistory()only protects concurrent calls within the same instance. If two parallel tabs (different instances) callupdateTaskHistory()simultaneously:updateTaskHistory(taskX)→ reads current stateupdateTaskHistory(taskY)→ reads same stale state (before Tab A's write)Fix
Add a global file-level lock (
_history.lock) viaproper-lockfileinTaskHistoryStore.withLock()so that mutations from different ClineProvider instances (parallel tabs) are serialized, preventing stale-cache overwrites.Changes
proper-lockfileand addgetGlobalLockFilePath()helperwithLock()before in-process serializationTesting Requirements
Related Issues