Remove globals & refactor into structs - #52
Merged
Merged
Conversation
alexcb
self-requested a review
March 25, 2024 18:11
alexcb
reviewed
Mar 25, 2024
| } | ||
|
|
||
| func (s *simpleSolver) exploreVertices(e Edge) ([]digest.Digest, map[digest.Digest]Vertex) { | ||
| type flightControl struct { |
Contributor
There was a problem hiding this comment.
Can we use a different name so that this doesn't conflict with the util/flightcontrol package? Otherwise it could be confusing understanding which flightcontrol is being referenced (either in code, or conversations about the code)
Contributor
Author
There was a problem hiding this comment.
Ha, sure. I used that name because I couldn't think of a better one. Any suggestions?
Contributor
There was a problem hiding this comment.
namedLockManager, parallelGuard, executionLocker?
alexcb
approved these changes
Mar 25, 2024
alexcb
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.