Add new registry "cap" - #27
Merged
Merged
Conversation
mikejholly
marked this pull request as ready for review
October 4, 2023 19:54
alexcb
approved these changes
Oct 4, 2023
mikejholly
force-pushed
the
mh/registry-caps
branch
from
October 5, 2023 00:14
e9fbad4 to
9d49b85
Compare
mikejholly
force-pushed
the
mh/registry-caps
branch
from
October 5, 2023 00:16
9d49b85 to
7dfd9c2
Compare
mikejholly
added a commit
to earthly/earthly
that referenced
this pull request
Oct 5, 2023
This PR moves the registry proxy start-up code into `Builder` and gates the feature using the new cap added here: earthly/buildkit#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new capability for the registry proxy to the existing set. earthly/earthly#3343