Skip to content

fix: raise DeFindex rpc.Server timeout above withSorobanTimeout so outer race fires first - #243

Merged
collinsezedike merged 1 commit into
mainfrom
fix/defindex-rpc-timeout-order
Jun 25, 2026
Merged

collinsezedike merged 1 commit into
mainfrom
fix/defindex-rpc-timeout-order

Conversation

@collinsezedike

@collinsezedike collinsezedike commented Jun 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Changes the rpc.Server HTTP timeout in fetchDefindexPosition from 8_000 to 12_000 ms so the SDK-level AbortSignal fires at 12 s, after the withSorobanTimeout race at 10 s
  • Previously the SDK aborted at 8 s with an opaque Axios/fetch error before the outer race could produce the readable "Soroban RPC timed out after 10000ms" message
  • Updates the test assertion to match the new value and clarifies why the timeout must exceed withSorobanTimeout

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally
  • pnpm --filter @meridian/stellar-sdk-helpers run test shows 80 passing

Closes #235

@vercel

vercel Bot commented Jun 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
meridian Ready Ready Preview, Comment Jun 24, 2026 3:17pm

@collinsezedike
collinsezedike merged commit 6c04839 into main Jun 25, 2026
5 checks passed
@collinsezedike
collinsezedike deleted the fix/defindex-rpc-timeout-order branch June 25, 2026 15:51

This branch was successfully deployed

1 active deployment
Preview — 6c44568f Deployed Jun 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] DeFindex SDK timeout produces opaque Axios error instead of readable message

1 participant