Repository navigation
fix: clear timeout handle on resolve and consolidate withRaceTimeout - #241
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e timeout pattern
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withRaceTimeouthelper inpackages/sharedthat properly callsclearTimeouton both resolve and reject paths, eliminating the timer leak present in the oldPromise.racepatternwithSorobanTimeoutintx.tsandwithTimeoutinblend.tswith thin wrappers overwithRaceTimeout, removing the two independent copies of the same leaky implementationwithRaceTimeoutcovering the happy path, timeout path, and clearTimeout-on-resolve/reject behaviorTest plan
pnpm lint && pnpm typecheck && pnpm testpass locallypnpm --filter @meridian/shared run testshows 14 passing (4 new)pnpm --filter @meridian/stellar-sdk-helpers run testshows 80 passingCloses #233