Repository navigation
fix: scrub RPC URLs and contract addresses from 500 error responses - #215
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeTxError(err, fallback)helper to@meridian/sharedthat extracts only the first line of an error message and drops it if it contains an RPC URL or Stellar contract addresserr.messageexposures in the four Vercel tx handlers and the Fastify tx route withsanitizeTxError, keeping user-facing messages (e.g. "All required trustlines already exist") while scrubbing deployment detailsTest plan
sanitizeTxErrorunit tests inpackages/shared/src/utils.test.tscover: non-Error values, multi-line messages, RPC URL in first line, C-address in first line, empty message, and clean user-facing messagepackages/sharedpassCloses #180