Skip to content

ApiRoute: Provide a hash implementation, too.#261

Merged
aelawson merged 2 commits intodropbox:mainfrom
yanks:jforbes-hash-too
Jan 10, 2022
Merged

ApiRoute: Provide a hash implementation, too.#261
aelawson merged 2 commits intodropbox:mainfrom
yanks:jforbes-hash-too

Conversation

@yanks
Copy link
Copy Markdown
Contributor

@yanks yanks commented Jan 7, 2022

This adds a hash implementation to ApiRoute as well, as it is required by some downstream code.

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2022

Codecov Report

Merging #261 (616dc74) into main (32b0c0f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   51.64%   51.65%   +0.01%     
==========================================
  Files          37       37              
  Lines        8423     8425       +2     
  Branches     1794     1794              
==========================================
+ Hits         4350     4352       +2     
  Misses       3757     3757              
  Partials      316      316              
Flag Coverage Δ
unit 51.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/ir/api.py 82.11% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b0c0f...616dc74. Read the comment docs.

@yanks yanks requested review from aelawson, rogebrd and svpranay January 8, 2022 00:11
Copy link
Copy Markdown
Contributor

@aelawson aelawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/ offline review from jrm

@aelawson aelawson merged commit b7b6432 into dropbox:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants