Add ability to dynamically import namespaces from types in the tsd client#235
Add ability to dynamically import namespaces from types in the tsd client#235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 51.72% 51.64% -0.08%
==========================================
Files 37 37
Lines 8370 8390 +20
Branches 1786 1789 +3
==========================================
+ Hits 4329 4333 +4
- Misses 3727 3743 +16
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eugeneyche
left a comment
There was a problem hiding this comment.
Overall looks good; accepting; consider addressing typo comment.
| import_template_string = self.args.import_template_string | ||
| import_from_file = self.args.types_file | ||
| # /*IMPORT*/ | ||
| i_match = re.search("/\\*%s\\*/" % (import_template_string), template) |
There was a problem hiding this comment.
LOL this seems super manual, but I see it used in other places. Have we considered using an actual template language library?
| '--types-file', | ||
| type=str, | ||
| default='', | ||
| help=('If using the --import-namespaces flag, this if the file that contains ' |
Checklist
General Contributing
Is This a Code Change?
Validation
tox?