Skip to content

Convert obj-c and swift pattern to str#204

Merged
rogebrd merged 1 commit intodropbox:mainfrom
changusmc:main
Dec 3, 2020
Merged

Convert obj-c and swift pattern to str#204
rogebrd merged 1 commit intodropbox:mainfrom
changusmc:main

Conversation

@changusmc
Copy link
Copy Markdown
Contributor

The pattern is currently a bytestring, and the app is failing to compile

pattern:@"b"^['&A-Za-z0-9._%+-]+@[A-Za-z0-9-][A-Za-z0-9.-]*\\\\.[A-Za-z]{2,15}$"

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • [] Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2020

Codecov Report

Merging #204 (0922df3) into main (27a566a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   51.72%   51.72%           
=======================================
  Files          37       37           
  Lines        8369     8369           
  Branches     1786     1786           
=======================================
  Hits         4329     4329           
  Misses       3726     3726           
  Partials      314      314           
Flag Coverage Δ
unit 51.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/obj_c_types.py 0.00% <ø> (ø)
stone/backends/swift_types.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a566a...0922df3. Read the comment docs.

@greg-db greg-db requested a review from rogebrd December 3, 2020 16:38
@rogebrd rogebrd merged commit a8d47a6 into dropbox:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants