[arnoldlaishram]

Summary

Adds a new finalrun-test-and-fix skill at skills/finalrun-test-and-fix/SKILL.md that orchestrates the full FinalRun loop end-to-end: deep-dive a feature and author tests via finalrun-generate-test, run them via finalrun-use-cli, then triage failures from CLI artifacts and fix app code or tests until the run is green.

Key behaviors encoded in the skill:

• Hypothesis, not fix. Suspicious code found while exploring is recorded as a hypothesis; no source edits happen before the test runs.
• Strict order. Generate → finalrun check clean → execute → only then read artifacts and apply fixes.
• Fail-fast iteration. Defaults to finalrun test <selectors> against the touched spec(s); never escalates to finalrun suite unless the user asks.
• Build confirmation. Always asks the user whether to rebuild the app or run against an existing build before executing — never rebuilds silently.
• Artifact-driven triage. Diagnoses from result.json, actions/, screenshots, recording, and logs; classifies failures (test wording vs. app bug vs. env/secret blocker) before editing.
• Clear delegation. YAML authoring routes back to finalrun-generate-test; CLI/flag/artifact semantics route to finalrun-use-cli.

Summary by CodeRabbit

• Documentation
  • Added edge-case & state-analysis guidance to test generation, covering auth/onboarding, permission-dependent flows, empty/error/validation/boundary scenarios, and idempotent setup/cleanup instructions
  • Added an end-to-end “FinalRun” test-and-fix workflow with structured run/diagnosis steps, failure classification, narrow remediation guidance, re-run rules, and a README usage example for debugging failing tests

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9e5d1496-72bf-40fc-91da-1d7e78fd8073

📥 Commits

Reviewing files that changed from the base of the PR and between 359a3e2 and c8694d3.

📒 Files selected for processing (1)

• README.md

✅ Files skipped from review due to trivial changes (1)

• README.md

---

📝 Walkthrough

Walkthrough

Two documentation skills were changed: finalrun-generate-test gained a new "Step 1B — Edge Case & State Analysis" section; a new finalrun-test-and-fix skill was added to define the end-to-end test execution and failure-handling workflow.

Changes

Cohort / File(s)	Summary
Test generation skill skills/finalrun-generate-test/SKILL.md	Added "Step 1B — Edge Case & State Analysis" to instruct agents to detect state-dependent UI flows (auth, onboarding, feature flags) and boundary/error scenarios; updated plan to include grouped "Edge cases identified" and selection plus Setup & Idempotent Cleanup Rule.
Orchestrator / Test-fix skill skills/finalrun-test-and-fix/SKILL.md	New skill added describing strict end-to-end control flow: call finalrun-generate-test, require finalrun check cleanliness, run via finalrun-use-cli (handling rebuild vs reuse, --env, --platform), diagnose failures from CLI artifacts, classify failure types, prescribe narrow fixes, and define rerun/stop conditions.
Documentation surface README.md	Added "Debug and fix failing tests" section describing the new /finalrun-test-and-fix skill, its flow (generate → run → diagnose → fix → rerun) and an Android usage example.

Sequence Diagram(s)

sequenceDiagram
  participant Author
  participant Gen as finalrun-generate-test
  participant CLI as finalrun-use-cli
  participant Art as CLI artifacts (result.json, screenshots, logs)
  participant Fixer as finalrun-test-and-fix

  Author->>Gen: request test generation (including Step 1B)
  Gen-->>Author: produced/updated tests + edge-case list
  Author->>CLI: run tests (choose rebuild vs reuse, set --env/--platform)
  CLI->>Art: produce artifacts
  Art-->>Fixer: provide result.json, actions/, screenshots, logs
  Fixer->>Author: classify failure and recommend narrow fixes or re-run
  Author->>CLI: re-run after fixes (loop until green or stop)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Skill: avoid verifying ephemeral UI in generated tests #83 — Overlaps edits to skills/finalrun-generate-test/SKILL.md regarding edge‑case/state guidance and transient UI assertions.
• docs: restructure README for onboarding-first experience #70 — Related changes to README content and the "debug and fix failing tests" workflow.
• Add use-finalrun-cli skill #34 — Introduces related CLI/skill integration (finalrun-use-cli) that the new orchestrator skill invokes.

Suggested labels

documentation

Suggested reviewers

• droid-ash

Poem

🐰 I hopped through code and found a clue,
Edge cases hiding out of view,
Step 1B sniffed each state and gate,
Test-and-fix helps set things straight,
Now tests and tails both hop anew. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Added new skill to test and fix any issues' is vague and does not clearly identify which skill was added or what the main change is. While it mentions a new skill, 'test and fix any issues' is overly generic and does not specify the skill's name (finalrun-test-and-fix) or its primary purpose as an orchestrator for the FinalRun loop.	Replace with a more specific title like 'Add finalrun-test-and-fix skill for orchestrating end-to-end test generation and failure remediation' to clearly communicate the skill name and its core orchestration purpose.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test-and-fix-skill

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}