docs(501): post-base-merge toolchain and base-reconciliation evidence - #660
Merged
drmoisan merged 2 commits intoAug 28, 2026
Conversation
…vidence Re-merged epic/quickfiler-bug-family-integration tip 5793b8c (sibling 476, PR #658) into bug/breadcrumb-coordinator-hub-defects-501 and re-ran the full C# toolchain against the reconciled head. - csharpier check: 1547 files, 0 rewrites - msbuild /t:Rebuild analyzers: 0 errors, 0 CoreCompile skips, 51 CoreCompile targets - msbuild /t:Rebuild TreatWarningsAsErrors: 0 errors, 0 CoreCompile skips - MSTest with coverage: 6745/6745 passed, line-rate 85.1494%, branch-rate 79.1998% Base reconciliation proves 0 behind after the merge, justifies the single pure-deletion file as a partial-class relocation, and shows all twelve merged sibling entries (493, 444, 476) intact in QuickFiler.Test.csproj. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
drmoisan
merged commit Aug 28, 2026
38f0978
into
epic/quickfiler-bug-family-integration
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(501): post-base-merge toolchain and base-reconciliation evidence
Docs-only follow-up to PR #659 (epic child
breadcrumb-coordinator-hub-defects-501). It adds thefive QA-gate evidence artifacts that attest the tree actually merged into
epic/quickfiler-bug-family-integrationpasses the full C# toolchain. No production or test sourcefile is touched.
Why this follow-up exists
PR #659 was reviewed and gated against head
d86ee40d, whose CI run33128535269concludedsuccess. Sibling 476 then merged as PR #658 (5793b8c7), leavingd86ee40deleven commits behindthe integration tip, so run
33128535269no longer gated the tree that would result from merging.This branch was therefore re-merged onto
5793b8c7(merge commit9c6c0b4a) and the full toolchainwas re-run against the reconciled tree. While that pass was in flight, PR #659 was merged as
4cb709db. That merge commit's tree is0bdc974e...— byte-for-byte identical to the tree of thelocal reconciliation merge
9c6c0b4a— so the toolchain results recorded here describe exactly thetree now on the integration branch. Only the evidence itself remained unlanded, and this PR lands it.
Contents
Five artifacts under
docs/features/active/breadcrumb-coordinator-hub-defects-501/evidence/qa-gates/,all timestamped
2026-08-28T00-14:post-basemerge-base-reconciliationpost-basemerge-csharpierChecked 1547 files, 0 rewrites, EXIT 0post-basemerge-msbuild-analyzerspost-basemerge-msbuild-nullablepost-basemerge-test-coverageToolchain results recorded
Run in the mandated order with no step rewriting a file, so the loop did not restart:
dotnet tool run csharpier format ./check .—Checked 1547 files in 4975ms, EXIT 0.msbuild TaskMaster.sln /t:Rebuild /m /p:Configuration=Debug "/p:Platform=Any CPU" /p:EnableNETAnalyzers=true /p:EnforceCodeStyleInBuild=true—0 Error(s), EXIT 0.msbuild TaskMaster.sln /t:Rebuild /m /p:Configuration=Debug "/p:Platform=Any CPU" /p:TreatWarningsAsErrors=true—0 Error(s), EXIT 0.pwsh -NoProfile -File ./scripts/vscode/Invoke-MSTestWithCoverage.ps1 -SearchRoot . -Configuration Debug -CoverageOutput coverage/postchange.cobertura.xml—Total tests: 6745, Passed: 6745, EXIT 0.Coverage on the reconciled tree:
line-rate85.1494% (54545 / 64058),branch-rate79.1998%(12965 / 16370). Both clear the uniform
>= 85%line and>= 75%branch floors.Analyzer and nullable gates are non-vacuous
Both MSBuild steps used
/t:Rebuild, never/t:Build. Counted against the build logs, theSkipping target "CoreCompile"count is 0 for both, against 51 and 65 realCoreCompiletarget executions respectively. A warm
/t:Buildwould have skipped every project and run noanalyzer at all, so this records a gate that could actually have failed.
One recorded environmental test re-run
The first coverage attempt exited
-1after 1694 passing tests with zero failing tests and no runsummary — the signature of an aborted host rather than a failing assertion, with two sibling children
building concurrently in adjacent worktrees. One re-run was taken on the byte-identical tree and is
the run recorded above. No source file changed between the two attempts.
Base reconciliation
git rev-list --left-right --count origin/epic/quickfiler-bug-family-integration...HEADreported0 6after the reconciliation merge: zero base-only commits, so the integration tip is contained infull.
The pure-deletion scan reported one row,
0 50 QuickFiler/Viewers/BreadcrumbBridgeCoordinator.cs.The invariant that matters is that no file loses content the base gained, and it holds here on two
independent grounds:
4f238289..5793b8c7touched that file, so it held no base-gainedcontent to lose;
SetSuggestions,SuggestionsUpgrade,PopulateSuggestionsAsyncandAddItems, all four of which are present in the new partialQuickFiler/Viewers/BreadcrumbBridgeCoordinator.Suggestions.cs. The type ispartial, so thepublic surface is unchanged; the split exists to hold the file under the 500-line limit.
Merged siblings' project-file entries preserved
QuickFiler.Test/QuickFiler.Test.csprojretains all twelve entries contributed by merged siblings —493's two
Controllers\QfcItemController.UiThreadDispatcherFixture*entries, 444's eightControllers\QfcCollectionController*entries, and 476's twoViewers\WebView2*entries — unmovedand unreplaced. This feature's own single added entry stays inside the
Viewers\Breadcrumb*region.CI gate
Workflow-dispatch run
33129199041on head51cfa948concludedsuccesswith all five requiredchecks green:
format-check,build-analyzers,build-nullable,mstest-coverage,actionlint..github/workflows/ci.ymlfirespull_requestonly onmainanddevelopment, so a PR into theepic integration branch receives no automatic checks and the gate is dispatched explicitly. No
workflow file is modified by this PR.
Issue linkage
This PR targets
epic/quickfiler-bug-family-integration, not the default branch, so GitHub registersno closing references from it. Issues #501, #462, #500 and #502 are addressed by the code already
merged in PR #659 and are closed at epic fan-in, not here. Issue #657 tracks the three non-blocking
review residuals dispositioned during the #659 review and stays open.
Risk
Documentation only: 5 added files, 213 insertions, 0 deletions, no file outside the feature's own
evidence/qa-gates/directory.