Preserve archive-relative Efc filing destinations - #611
Merged
drmoisan merged 5 commits intoAug 25, 2026
Conversation
drmoisan
force-pushed
the
bug/efc-full-path-destination-resolution-regression-609
branch
from
August 25, 2026 19:07
fc89b01 to
dbfe1b9
Compare
drmoisan
enabled auto-merge
August 25, 2026 19:08
drmoisan
added a commit
that referenced
this pull request
Aug 25, 2026
… spec Pull request #611 (issue #609) changed two files this plan cites as READ-ONLY, leaving four recorded figures stale. One of them broke an acceptance condition: [P0-T8] required the Phase 0 read artifact to list all seven method names in BreadcrumbBridgeRouterIssue439Tests.cs, but the file now carries ten, and the three new Issue609_* methods are exactly the assertions a later phase is most likely to duplicate. Corrected, measured against integration head 59939f8: - BreadcrumbBridgeRouterIssue439Tests.cs 531 -> 694 lines, 7 -> 10 methods - FolderPredictor.cs 983 -> 1000 lines - FolderPredictorTests.cs 985 -> 1043 lines (found by sweep) [P0-T8] now names the three Issue609_* methods verbatim and derives its listed-name count from a recorded grep, so the artifact stays correct if the file gains further methods before execution. [P7-T2] keeps its baseline-relative clause as the binding gate; its absolute figures are demoted to advisory context that the P0-T16 baseline overrides. Both files remain READ-ONLY / MUST-NOT-WRITE for this feature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
5 tasks
drmoisan
deleted the
bug/efc-full-path-destination-resolution-regression-609
branch
August 28, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IFolderHierarchyProvider.ResolveLeafKeyAsync.EmailFilerConfigfrom receiving a full hierarchy path and prefixing the archive root a second time.@mailbox-root filing behavior retain the established path-representation boundary.Why
FolderPredictorstartup suggestion generation could present a persisted in-root full Outlook hierarchy path verbatim. If that value crossed into the filing boundary,EmailFilerConfigcombined it withOlAncestoragain, producing a duplicated archive root and no resolved destination.Efc intentionally uses two destination representations: a full Outlook hierarchy path for hierarchy lookup and an archive-relative target for filing. This change maintains that boundary.
What Changed
FolderScorekey aligned with the projected display value.Verification
ProjectSuggestionPathline and branch coverage: 100%.GitHub Auto-close
Closes #609