chore(memory): record two orchestrator lessons from the #441 child run - #539
Merged
drmoisan merged 1 commit intoAug 11, 2026
Conversation
- mcp-tools-available-to-orchestrator: confirm that atomic-executor's MCP surface is exactly the four PoshQC tools, so a worker reporting the promotion tools missing is telling the truth about its own session. A plan's sanctioned POSTING BLOCKED branch is a handoff to a more privileged session, not a permanent deferral: the orchestrator should file the issues itself and append a RESOLUTION section rather than rewriting the worker's honest blocked record. - collect-pr-context-lands-in-main-checkout: collect_pr_context can return ok:true over a pre-existing pr_context.summary.txt it did not write. On #441 the file still carried a feature-review subagent's hand-authored content, including a stale Base and a first line claiming the tool was unavailable. Author the PR body from the real git diff, not the summary. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cobertura-coverage-arithmetic) of thebuild-ci-coverage-gate-fidelityepic..claude/agent-memory/orchestrator/are extended. No production code, tests, configuration, or policy files are touched.Why
Both lessons cost real time on the #441 run and would recur on every future epic child.
Subagent MCP surface is narrower than the orchestrator's.
atomic-executoris exposed exactly four MCP tools (the PoshQC format/analyze/test/autofix set). The promotion-lifecycle tools are genuinely absent from it. When the #441 plan reached its Phase 6 follow-up filing, the executor correctly took the plan's sanctionedPOSTING BLOCKEDbranch and left AC-20 unchecked rather than fabricating issue numbers. The existing memory already said "run the tools yourself"; what it lacked was the recognition that a plan's blocked-branch is a handoff to a more privileged session rather than a permanent deferral, and the instruction to append aRESOLUTIONsection rather than rewrite the worker's honest blocked record.collect_pr_contextcan report success over a file it did not write. On this run the tool returnedok:truewith correct worktree paths, butartifacts/pr_context.summary.txtwas untouched: its mtime and content still belonged to a file thefeature-reviewsubagent had hand-authored an hour earlier, whose first line read "collect_pr_context MCP tool unavailable in this session" and whoseBase:was the old pre-change baseline rather than the--basethat was passed. Authoring a PR body from that summary would have described the wrong diff against the wrong base.What Changed
.claude/agent-memory/orchestrator/mcp-tools-available-to-orchestrator.md— adds a confirmation paragraph namingatomic-executor's exact four-tool surface and the resolve-don't-accept protocol for a plan's sanctioned blocked branch..claude/agent-memory/orchestrator/collect-pr-context-lands-in-main-checkout.md— strengthens the existing "quirk (a)" note from "does not rewrite on a second call" to "can report success over a pre-existing file it did not write", with the three practical consequences.Architecture / How It Fits Together
Not applicable. These are agent-memory notes, which are version-controlled so they are shared across sessions and team members rather than held per-session.
Verification
Completed
No toolchain stage applies: the diff contains only Markdown under
.claude/agent-memory/. No*.ps1,*.cs,*.py, or*.tsfile is touched, and no test, formatter, linter, or analyzer input changes.Recommended
None.
Backward Compatibility / Migration Notes
None. Documentation-only change, additive to two existing files.
Risks and Mitigations
.claude/agent-memory/**Review Guide
Two files, both additive prose. Read the diff top to bottom; there is no ordering constraint.
Follow-ups
None. The six follow-up issues surfaced by #441 (#529, #530, #531, #532, #536, #537) are recorded in that feature's PR and evidence.
GitHub Auto-close