fix(UtilitiesCS.Test): remove duplicate PercentageFormatterTests compile entry (CS2002) - #533
Merged
Conversation
…ile entry UtilitiesCS.Test.csproj listed <Compile Include="OutlookObjects\Folder\PercentageFormatterTests.cs" /> twice (lines 304 and 356), which made csc emit warning CS2002: Source file ... specified multiple times on every build. Delete the second occurrence and keep the first. This is a build-configuration change only: no .cs file is touched, no behavior changes, and the PercentageFormatterTests test count is unchanged at 7. Evidence captured under the feature folder: - fail-before: direct-project /t:Rebuild reproduces CS2002 (6 warnings) - pass-after: same /t:Rebuild emits zero CS2002 (5 warnings) - CI-equivalent solution /t:Rebuild with TreatWarningsAsErrors=true exits 0 - scoped vstest run: 7 tests, 7 passed, before and after Refs #394 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…hell helper Feature review raised one blocking finding: the executor retained docs/features/.../evidence/baseline/duplicate-sweep.ps1 for reproducibility, which put PowerShell into the branch's changed-language set and triggered a mandatory coverage-verification obligation with no Pester test, no PoshQC run, and no artifacts/pester/powershell-coverage.xml behind it. The plan never required committing the script - only capturing its output. That output, and the script's logic, are already recorded verbatim in the sibling evidence/baseline/duplicate-sweep.2026-08-10T22-31.md, so removing the .ps1 loses nothing and clears the changed-language signal at its source. Also folded in the two non-blocking review follow-ups: - corrected three stale figures in spec.md's duplicate-sweep table to match the captured evidence (Analyzer 9 -> 11, Reference ~114 -> 126, packages.config ~99 -> 105); the "no duplicates" conclusion is unchanged - added evidence/qa-gates/analyzer-not-applicable artifact for parity with the existing CSharpier and nullable-gate determinations Zero .cs files changed this cycle, so the C# build and vstest gates were not re-run; that determination is recorded rather than silently omitted. UtilitiesCS.Test.csproj is untouched by this cycle. Also commits the feature-review and remediation audit artifacts. Refs #394 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
P2-T1 and P2-T2 could not resolve while the git rm was staged rather than
committed, so they were re-run against the committed state.
P2-T1 now passes: the merge-base diff and porcelain status together contain
zero .ps1/.psm1/.psd1 paths, which is the condition this cycle exists to
establish.
P2-T2's original acceptance ("no path outside the feature folder other than the
.csproj") was over-broad: it failed on
.claude/agent-memory/feature-review/project_durable-feature-script-triggers-python-coverage-gate.md,
a two-line memory-index append written by the feature-review subagent during
this feature's own audit. That is not a scope violation and reverting it would
discard a legitimate memory record, so the clause was revised mid-execution
through the planner rather than reinterpreted at execution time.
The revised acceptance splits into four clauses and is strictly narrower than a
blanket exclusion: it still fails on CLAUDE.md, .claude/rules/**, scripts/**,
any .cs file, any other .csproj, and any coverage-threshold change, and its
.ps1/.psm1/.psd1 clause takes no exclusion at all. The evidence artifact must
enumerate every out-of-feature-folder path by name so the agent-memory file is
visible to a reviewer rather than silently swallowed.
All 15 remediation-plan tasks are now checked off.
Refs #394
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Reaudit of branch HEAD f39c6fc9 against the epic integration base, written with a fresh exit timestamp so the 2026-08-10T23-45 entry audits stay intact. Independently re-derived from the diff rather than read off the remediation narrative: - zero .ps1/.psm1/.psd1 paths in the merge-base diff and a clean porcelain status, closing the entry audit's sole blocking finding - UtilitiesCS.Test.csproj still exactly 1 deletion / 0 insertions, unregressed - the mid-execution [P2-T2] acceptance revision was compared against its original text recovered from 2a2116eb and judged legitimate: it carves out only the verified two-line .claude/agent-memory append and re-states every substantive prohibition, with the .ps1 check exempt from any carve-out - spec.md's three corrected sweep figures verified numerically against the captured sweep evidence - authoritative AC count established at 8 (spec.md), all delivered; issue.md's non-authoritative mirror carries 6 Remediation cycle 1 exit condition met. Refs #394 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
drmoisan
added a commit
that referenced
this pull request
Aug 11, 2026
Feature 394 merged via PR #533 (c1fe356) and its worktree removed. Records that ci.yml's pull_request trigger excludes the integration branch, so child PRs carry no CI and the integrated tree is gated by workflow_dispatch plus the final main-based integration PR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
drmoisan
added a commit
that referenced
this pull request
Aug 15, 2026
Feature 394 merged via PR #533 (c1fe356) and its worktree removed. Records that ci.yml's pull_request trigger excludes the integration branch, so child PRs carry no CI and the integrated tree is gated by workflow_dispatch plus the final main-based integration PR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
drmoisan
deleted the
bug/utilitiescs-test-cs2002-duplicate-compile-entry-394
branch
August 15, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(UtilitiesCS.Test): remove duplicate PercentageFormatterTests compile entry (CS2002)
Summary
<Compile Include="OutlookObjects\Folder\PercentageFormatterTests.cs" />item fromUtilitiesCS.Test/UtilitiesCS.Test.csproj, eliminating thewarning CS2002: Source file ... specified multiple timesemitted on every build of that project..csfiles touched, so there is no behavior change and no changed-line coverage surface./t:Rebuildcommand: 6 warnings before, 5 after, withCS2002present then absent.PercentageFormatterTeststest count is unchanged at 7 passing, before and after.build-ci-coverage-gate-fidelityepic. Base is the epic integration branch, notmain.Why
UtilitiesCS.Test.csprojlisted the same source file twice, at line 304 and line 356. The two lines were byte-identical. MSBuild passes both tocsc, which reportsCS2002and compiles the file once. The warning is therefore harmless at runtime but permanently noisy, and it is the kind of residual warning that erodes the signal value of a build log — directly relevant to this epic's build/CI gate fidelity objective.A duplicate sweep across every item type in the project file (
Compile,EmbeddedResource,None,Reference,ProjectReference,BootstrapperPackage,Analyzer,AdditionalFiles) plus every<package>entry inpackages.configfound exactly one duplicate — the one fixed here — and zero duplicates anywhere else.What Changed
Production (1 file)
UtilitiesCS.Test/UtilitiesCS.Test.csproj— deleted the second occurrence at line 356, retained line 304. Total<Compile Include=count 452 → 451. CRLF line endings preserved; no reformatting.Docs and evidence (this feature folder only)
spec.md,issue.md,plan.2026-08-10T14-09.md— acceptance-criteria and task check-offs; three figures in spec.md's duplicate-sweep table corrected to match the captured evidence (Analyzer9 → 11,Reference~114 → 126,packages.config~99 → 105). The table's "no duplicates" conclusion is unchanged.evidence/**— baseline, regression-testing, and QA-gate artifacts, each recordingTimestamp:,Command:,EXIT_CODE:,Output Summary:.policy-audit.*,code-review.*,feature-audit.*at both the entry (2026-08-10T23-45) and exit (2026-08-11T04-05) timestamps, plusremediation-inputs.*andremediation-plan.*for cycle 1.Other (1 file)
.claude/agent-memory/feature-review/project_durable-feature-script-triggers-python-coverage-gate.md— a two-line memory-index append written by the review subagent during this feature's own audit. No production surface.Architecture / How It Fits Together
No architectural change. This is a build-configuration edit inside one test project's item group. Nothing is added, removed, renamed, or rewired; the compiler already deduplicated the file, so the compiled output is byte-for-byte equivalent.
Verification
Completed
MSBuild UtilitiesCS.Test\UtilitiesCS.Test.csproj /t:Rebuild /p:Configuration=Debug /p:Platform=AnyCPUCSC : warning CS2002present; 6 Warning(s), 0 Error(s)CS2002; 5 Warning(s), 0 Error(s)MSBuild TaskMaster.sln /t:Rebuild /m /p:Configuration=Debug '/p:Platform=Any CPU' /p:TreatWarningsAsErrors=trueCS2002across 6976 output lines; only 5 pre-existing unrelatedSystem.Reactivewarningsvstest.console.exe UtilitiesCS.Test.dll /InIsolation /TestCaseFilter:'FullyQualifiedName~PercentageFormatterTests'packages.config/t:Rebuildrather than/t:Buildis load-bearing: a/t:Buildafter any earlier build skipsCoreCompileand would have returned success having compiled nothing, making the fail-before gate vacuous.Deliberately not run, each with a recorded rationale artifact
.csfiles touched;.claude/rules/csharp.mdscopes it to*.cs./p:Nullable=enable— a known repository defect (issue Bug: claudemd-nullable-gate-diverges-from-ci #522): it does not matchci.ymland produces roughly 200-414 spuriousCS86xxerrors on a cleanmain. The CI-equivalent solution build above is the applicable type-check gate..cssource lines changed, so there is no changed-line coverage surface to regress.Recommended for the reviewer
Confirm no
CS2002forPercentageFormatterTests.csin the output.Backward Compatibility / Migration Notes
None. No public API, no behavior, no test surface, and no build output changes. The removed line was redundant to the compiler.
Risks and Mitigations
1 -/0 +<Compile Include=count went 452 → 451, and the 7PercentageFormatterTeststests still discover and pass/t:RebuildforcesCoreCompile; the warning is demonstrably present before and absent after under the same commandRollback is a one-line revert.
Review Guide
UtilitiesCS.Test/UtilitiesCS.Test.csproj— the entire production change, one deleted line.evidence/baseline/fail-before-cs2002.*.mdandevidence/qa-gates/post-fix-cs2002.*.md— the before/after pair.feature-audit.2026-08-11T04-05.md— acceptance-criteria verdicts.Follow-ups
Remediation cycle 1 removed an unplanned
.ps1sweep helper that had been committed under the evidence tree. Retaining it would have placed PowerShell in the branch's changed-language set and triggered a mandatory coverage obligation with no Pester test or coverage artifact behind it. Its logic and complete output remain captured verbatim inevidence/baseline/duplicate-sweep.2026-08-10T22-31.md, so nothing was lost. The exit reaudit recorded 0 blocking findings.No deferred work.
GitHub Auto-close