Bug: itemviewer-display-and-folder-contract-defects

[drmoisan]

• Work Mode: full-bug

Summary

Five contract and state-handling defects across ItemViewer.FolderSearch.cs,
ItemViewer.DisplayState.cs, and ItemViewer.Commands.cs. All are out of scope to fix under epic
#136's no-behavior-change NFR.

Environment

(not provided in potential file)

Steps to Reproduce

(not provided in potential file)

Expected Behavior

(not provided in potential file)

Actual Behavior

(not provided in potential file)

Logs / Screenshots

(not provided in potential file)

Impact / Severity

(not provided in potential file)

Source

From: docs/features/potential/2026-08-07-itemviewer-display-and-folder-contract-defects.md

[drmoisan]

Closing as completed. Delivered via commits dca9110f ("fix(quickfiler): rename SetFolderItems, return bool from FocusSubject, drop the dialog read-back") and related work in the itemviewer-surface-defects-489 feature, merged into main via PR #669 ("fix(quickfiler): close ItemViewer surface defects #486 #487 #489 #490").

Confirmed directly against origin/main:

• QuickFiler/Viewers/IItemViewer.cs declares void AddFolderItems(string[] items); SetFolderItems no longer exists on the interface (repo-wide grep of production call sites shows only AddFolderItems).
• QuickFiler/Viewers/ItemViewer.FolderSearch.cs: FocusSearch() is now a bare forward TxtboxSearch.Focus() with no Invoke call.
• QuickFiler/Viewers/ItemViewer.DisplayState.cs:79: public bool FocusSubject() => LblSubject.Focus(); — returns bool, not void.
• FlagTaskDialogResult remains a plain property with no dialog read-back reintroduced.

AC lines 857-868 in docs/features/active/itemviewer-surface-defects-489/spec.md (the sole acceptance-criteria source for this full-bug feature) are checked [x] and map directly to this issue's five defects.

Verified during a full-repo bug sweep (2026-09-02). No branch or PR remains to ship; this was left open only as bookkeeping.