Skip to content

Bug: qfc-collection-controller-unreachable-load-paths #468

Description

@drmoisan
  • Work Mode: full-bug

Summary

Twelve members of QfcCollectionController, totalling roughly 227 lines, have no caller anywhere in
the solution. They are dead code that inflates the coverage denominator and, in one case, hides a
real defect behind an unreachable entry point.

Environment

  • OS/version: n/a (dead-code finding, established by static reference search)
  • Python version: n/a
  • Command/flags used: repository-wide reference search across QuickFiler, QuickFiler.Test, and
    all other projects in TaskMaster.sln
  • Data source or fixture: QuickFiler/Controllers/QfcCollectionController.cs

Steps to Reproduce

  1. Search the whole solution for callers of each of the following members of
    QuickFiler/Controllers/QfcCollectionController.cs:
    • WireUpKeyboardHandler (:1254)
    • AnyOpenDropDownsAsync (:1324)
    • LoadGroups_02cAsync (:587)
    • LoadGroups_02bAsync (:635)
    • LoadGroup_03bAsync (:654)
    • LoadConversationsAndFoldersAsync (:761)
    • LoadItemGroup (:776)
    • LoadSequentialAsync (:827)
    • LoadGroupSequential (:842)
    • CacheTlpForMove (:865)
    • SwapTlp (:870)
    • CaptureTlpTemplate (:1991)
  2. Confirm no production or test caller exists for any of them.
  3. Note LoadGroups_02bAsync is referenced only from a commented-out line at :402.
  4. Note the field _templateTlp (:70) is written only by the dead CaptureTlpTemplate, so it is
    dead state as well.

Expected Behavior

Production code should not retain unreachable members. Every member should either have a caller or be
removed, so that the coverage denominator reflects code that can actually run.

Actual Behavior

Roughly 227 lines of unreachable code sit in the largest file in the repository. Under epic #136's
per-file 80% line-coverage target these lines must either be covered by tests that exercise code no
production path reaches, or be removed.

Logs / Screenshots

Impact / Severity

  • Blocker
  • High
  • Medium
  • Low

Low functional risk, since none of it executes. The cost is real but indirect: a substantial share of
the file's coverage denominator is code that cannot be exercised through any production path, and one
of these members hides an active defect.

Source

From: docs/features/potential/2026-08-07-qfc-collection-controller-unreachable-load-paths.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions