Replaced visual regression PR comment with hide-and-recreate behavior.#2537
Conversation
WalkthroughThis PR contains two independent updates: a GitHub Actions workflow configuration change enabling sticky comment recreation on subsequent runs, and a maintenance documentation update clarifying constraints on wrapping ChangesCI Sticky Comment Lifecycle
Maintenance Documentation for ahoy
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
- Coverage 86.56% 86.11% -0.46%
==========================================
Files 94 87 -7
Lines 4660 4501 -159
Branches 47 3 -44
==========================================
- Hits 4034 3876 -158
+ Misses 626 625 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Added
hide_and_recreate: trueto themarocchino/sticky-pull-request-commentstep in thevr-reportjob of the visual regression workflow. This ensures every new VR comparison posts a fresh PR comment rather than silently editing the existing one - making it immediately visible when a new comparison run has occurred. Hardened the.vortex/CLAUDE.mdsnapshot update rules to prevent wrapper-script workarounds, and refreshed the installer fixture to match the updated template.Changes
.github/workflows/test-vr.yml- Addedhide_and_recreate: trueto the sticky PR comment step so each VR comparison run hides the previous comment and creates a new one, mirroring the behavior already used by the coverage comment inbuild-test-deploy.yml..vortex/CLAUDE.md- Added aHARD RULEblock forbidding any indirection (wrapper scripts, heredocs, temp files,bash -cstrings) aroundahoy update-snapshots. The only accepted alternative whencdcannot persist isahoy --file .vortex/.ahoy.yml update-snapshotsusing the ahoy pointer flag directly..vortex/installer/tests/Fixtures/handler_process/visual_regression_enabled/.github/workflows/test-vr.yml- Refreshed installer fixture to reflect thehide_and_recreate: trueaddition in the template workflow.Before / After