Pr/issue 502#511
Open
Jackzzey wants to merge 3 commits into
Open
Conversation
added 3 commits
May 7, 2026 17:21
…ed and making sure it uses the right reference in case angular change detect doesnt update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removeTaskType, removeTaskGroup, and removeTask methods previously used Array.indexOf for lookup, which relies on reference equality. Objects returned from the API are new instances, so indexOf returned -1, causing splice(-1, 1) to silently delete the last element in the array instead of the intended item.
Replaced with findIndex using group id and task id guarding the splice with idx > -1 check. Done the same for the scoreboard viewer and had id based lookup.
Added unit tests for removing covering: name/ID-based matching, cross-reference equality, missing item safety, cascade deletion, and selected task deselection.