Skip to content

feat: add configurable startupProbe for all dragonfly components#501

Merged
gaius-qi merged 2 commits intodragonflyoss:mainfrom
snigdhasambitak:feat/configurable-startup-probe
May 7, 2026
Merged

feat: add configurable startupProbe for all dragonfly components#501
gaius-qi merged 2 commits intodragonflyoss:mainfrom
snigdhasambitak:feat/configurable-startup-probe

Conversation

@snigdhasambitak
Copy link
Copy Markdown
Contributor

@snigdhasambitak snigdhasambitak commented May 5, 2026

What

Adds optional startupProbe to manager, scheduler, seedClient and client. Off by default, no behavior change unless enabled.

Why

Currently the chart only ships hardcoded readiness/liveness probes. On clusters where dfdaemon boot is slow (peer discovery, cache warm-up), the existing liveness probe can restart the container before it's actually up, or leave it NotReady well after dfdaemon is serving. startupProbe is the right fix but there's no way to set one through values today, so users end up patching rendered manifests.

Example

client:
  startupProbe:
    enable: true
    periodSeconds: 2
    failureThreshold: 90

Defaults give a 5 minute startup budget when enabled. Reuses the same grpc_health_probe exec the existing probes use, so no new image dependencies.

Chart bumped to 1.6.24, README regenerated via helm-docs.

Signed-off-by: Snigdha Aryakumar snigdha.sambit.ak@gmail.com

Signed-off-by: Snigdha Aryakumar <snigdha.sambit.ak@gmail.com>
@snigdhasambitak snigdhasambitak force-pushed the feat/configurable-startup-probe branch from 5286497 to adc6f86 Compare May 5, 2026 09:05
@snigdhasambitak
Copy link
Copy Markdown
Contributor Author

snigdhasambitak commented May 5, 2026

@imeoer @gaius-qi @CormickKneey could one of you add the enhancement label so the Classify PR check passes? External contributors can't apply labels themselves. Thanks.

@gaius-qi gaius-qi added the enhancement New feature or request label May 5, 2026
…configurable-startup-probe

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi enabled auto-merge (squash) May 7, 2026 09:41
@gaius-qi gaius-qi merged commit 89d3cb5 into dragonflyoss:main May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants