feat: add configurable startupProbe for all dragonfly components#501
Merged
gaius-qi merged 2 commits intodragonflyoss:mainfrom May 7, 2026
Merged
Conversation
Signed-off-by: Snigdha Aryakumar <snigdha.sambit.ak@gmail.com>
5286497 to
adc6f86
Compare
Contributor
Author
|
@imeoer @gaius-qi @CormickKneey could one of you add the |
…configurable-startup-probe Signed-off-by: Gaius <gaius.qi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds optional
startupProbeto manager, scheduler, seedClient and client. Off by default, no behavior change unless enabled.Why
Currently the chart only ships hardcoded readiness/liveness probes. On clusters where dfdaemon boot is slow (peer discovery, cache warm-up), the existing liveness probe can restart the container before it's actually up, or leave it NotReady well after dfdaemon is serving.
startupProbeis the right fix but there's no way to set one through values today, so users end up patching rendered manifests.Example
Defaults give a 5 minute startup budget when enabled. Reuses the same
grpc_health_probeexec the existing probes use, so no new image dependencies.Chart bumped to 1.6.24, README regenerated via helm-docs.
Signed-off-by: Snigdha Aryakumar snigdha.sambit.ak@gmail.com