Conversation
5f770fd to
57bed13
Compare
dpranke
left a comment
There was a problem hiding this comment.
Thanks for the PR! However, I was intentionally only running the oldest supported version and the two newest versions likely to introduce breakages. I don't think it's necessary to test every supported version of Python.
|
@dpranke I hear you. I don't have a strong opinion here but considering there isn't any significant cost to test all supported versions and this is the common approach, I'd still recommend adding them. Feel free to close the PR if there is no chance of a merge 🌻 |
|
That's fair. I don't have a strong opinion here, and as you say, the jobs aren't that costly. So, I'm okay with landing the ci.yml change, but as per the comments in the other PRs, let's revert the uv.lock change (if we can) and address that separately. |
When they are not strings, 3.10 is interpreted as 3.1 and causes CI to fail.
57bed13 to
1b763ae
Compare
|
I removed the commits from the other PRs - not sure why I stacked them in the first place. |
The project declares support for Python
>=3.8, <=3.13but several entries were missing in the test matrix.