Skip to content

Fix testing matrix#97

Merged
dpranke merged 2 commits intodpranke:mainfrom
ulgens:fix-testing-matrix
Dec 27, 2025
Merged

Fix testing matrix#97
dpranke merged 2 commits intodpranke:mainfrom
ulgens:fix-testing-matrix

Conversation

@ulgens
Copy link
Contributor

@ulgens ulgens commented Dec 27, 2025

The project declares support for Python >=3.8, <=3.13 but several entries were missing in the test matrix.

Copy link
Owner

@dpranke dpranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! However, I was intentionally only running the oldest supported version and the two newest versions likely to introduce breakages. I don't think it's necessary to test every supported version of Python.

@ulgens
Copy link
Contributor Author

ulgens commented Dec 27, 2025

@dpranke I hear you. I don't have a strong opinion here but considering there isn't any significant cost to test all supported versions and this is the common approach, I'd still recommend adding them.

Feel free to close the PR if there is no chance of a merge 🌻

@dpranke
Copy link
Owner

dpranke commented Dec 27, 2025

That's fair. I don't have a strong opinion here, and as you say, the jobs aren't that costly.

So, I'm okay with landing the ci.yml change, but as per the comments in the other PRs, let's revert the uv.lock change (if we can) and address that separately.

When they are not strings, 3.10 is interpreted as 3.1 and causes CI to fail.
@ulgens ulgens force-pushed the fix-testing-matrix branch from 57bed13 to 1b763ae Compare December 27, 2025 19:12
@ulgens
Copy link
Contributor Author

ulgens commented Dec 27, 2025

I removed the commits from the other PRs - not sure why I stacked them in the first place.

@ulgens ulgens marked this pull request as ready for review December 27, 2025 19:13
@ulgens ulgens requested a review from dpranke December 27, 2025 19:14
Copy link
Owner

@dpranke dpranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dpranke dpranke merged commit 6e7ee4d into dpranke:main Dec 27, 2025
6 checks passed
@ulgens ulgens deleted the fix-testing-matrix branch December 27, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants