Include signing key by BinLogToSln#183
Merged
Merged
Conversation
jaredpar
approved these changes
Apr 29, 2025
Merged
Member
Author
|
cc @ericstj |
Member
Author
|
@ericstj for a review here as well, thanks! |
ericstj
approved these changes
May 13, 2025
ericstj
left a comment
ericstj
left a comment
Member
There was a problem hiding this comment.
LGTM, sorry I missed the previous ping.
1 task
joperezr
added a commit
to joperezr/source-indexer
that referenced
this pull request
May 15, 2026
The fork has diverged ~21 commits since the last upstream sync (PR dotnet#184, 2025-05-12). Blindly re-running update-source-browser.ps1 risks silently dropping local features (dotnet#183 signing key, dotnet#192 dedup, dotnet#193 source-generated files, dotnet#255 net10 retarget, dotnet#257 Linux binlog fix, plus Dependabot bumps). - 02: prepend warning block to the 'Updating the vendored SourceBrowser' section listing the divergent PRs and recommending cherry-picks over a full re-sync. - 00: cross-reference the warning from the overview bullet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix errors like
error CS0281: Friend access was granted by 'Microsoft.CodeAnalysis, Version=42.42.42.42, Culture=neutral, PublicKeyToken=31bf3856ad364e35', but the public key of the output assembly ('') does not match that specified by the InternalsVisibleTo attribute in the granting assembly.
which break some references (i.e., some parts don't appear as links when they should be clickable).
When this is merged, new version of the BinLogToSln tool should be published (
not sure howlooks like the official build does this automatically), because it actually runs as part of other repos' official builds.