Include failing NuGet source in workload advertising manifest update errors - #55081
Merged
marcpopMSFT merged 4 commits intoJul 29, 2026
Merged
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add feed details to unauthorized error messages
Include failing NuGet source in workload advertising manifest update errors
Jun 30, 2026
marcpopMSFT
marked this pull request as ready for review
July 28, 2026 20:51
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
I was unable to test this to recreate the exact situation, but the change looks good to me. |
baronfel
approved these changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves diagnosability of workload advertising-manifest update failures by surfacing the specific failing NuGet source when protocol-level errors occur during package metadata queries.
Changes:
- Wrapes non-ignored
FatalProtocolExceptioninGetPackageMetadataAsync(...)with aNuGetPackageInstallerExceptionthat includes the failing source URL in the message. - Adds a unit test asserting the wrapped exception message includes the source and preserves the
FatalProtocolExceptionasInnerException.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs |
Wraps FatalProtocolException to include source context in surfaced errors. |
test/Microsoft.DotNet.PackageInstall.Tests/NuGetPackageInstallerTests.cs |
Adds test validating source-aware error messaging for failed protocol sources. |
Comment on lines
+929
to
+932
| catch (FatalProtocolException e) | ||
| { | ||
| throw new NuGetPackageInstallerException($"{string.Format(CliStrings.FailedToLoadNuGetSource, source.Source)}: {e.Message}", e); | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
marcpopMSFT
enabled auto-merge (squash)
July 29, 2026 00:08
baronfel
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workload advertising manifest updates on secured/inaccessible feeds surfaced repeated
401 Unauthorizedfailures without identifying which feed failed, making diagnosis difficult. This change propagates source context into the surfaced error so users can immediately identify the problematic feed.Error propagation: include source on protocol failures
NuGetPackageDownloader.GetPackageMetadataAsync(...)to wrap non-ignoredFatalProtocolExceptionwithNuGetPackageInstallerExceptionthat includes the failing source URL and original protocol message.WorkloadManifestUpdateralready reports the thrown exception message.Targeted coverage for source-aware failures
GivenAFailedSourceItShouldIncludeSourceInErrorinNuGetPackageInstallerTests.FatalProtocolExceptionasInnerException, and carries through the inner message.