Migrate Microsoft.DotNet.TemplateLocator.Tests to MSTest.Sdk on MTP - #54895
Merged
Evangelink merged 1 commit intoJun 22, 2026
Merged
Evangelink merged 1 commit into
Evangelink merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Microsoft.DotNet.TemplateLocator.Tests from the repo’s xUnit-based test setup to MSTest.Sdk running on Microsoft.Testing.Platform (MTP), aligning it with the ongoing test framework migration across dotnet/sdk.
Changes:
- Switched the test project SDK to
MSTest.Sdk, updated the test framework reference toMicrosoft.NET.TestFramework.MSTest, and removed the xUnit-eraOutputType=Execustomization. - Converted tests from xUnit attributes (
[Fact]) to MSTest attributes ([TestClass]/[TestMethod]). - Updated the test class to use the parameterless MSTest
SdkTestbase (removedITestOutputHelperconstructor injection).
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.DotNet.TemplateLocator.Tests/Microsoft.DotNet.TemplateLocator.Tests.csproj | Migrates the project to MSTest.Sdk/MTP and updates test framework wiring + global using. |
| test/Microsoft.DotNet.TemplateLocator.Tests/GivenAnTemplateLocator.cs | Converts the test class and methods from xUnit to MSTest and removes xUnit logger injection. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Member
Author
|
/ba-g #54819 |
Evangelink
enabled auto-merge
June 20, 2026 07:46
JeremyKuhne
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ongoing xUnit -> MSTest.Sdk (MTP) test migration. Migrates
Microsoft.DotNet.TemplateLocator.TeststoMSTest.Sdkon Microsoft.Testing.Platform, following the same pattern as the other migration PRs (builds on the foundation from #54845).Microsoft.NET.Sdk->MSTest.Sdk;Microsoft.NET.TestFrameworkproject reference ->Microsoft.NET.TestFramework.MSTest; removedOutputType=Exe; added theMicrosoft.NET.TestFrameworkglobal using.[Fact]->[TestMethod],[TestClass]added; removed theITestOutputHelperconstructor injection (baseSdkTestis now parameterless).Builds clean for the SDK target framework.