Repository navigation
Centralize per-platform default build timeouts in sdk-build template - #54804
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure Pipelines configuration to prevent macOS ARM64 legs from timing out by aligning their job timeout with the already-increased macOS x64 timeout.
Changes:
- Increase macOS ARM64 PR leg timeout to 90 minutes in
.vsts-pr.yml. - Increase macOS ARM64 CI (TestBuild) leg timeout to 90 minutes in
.vsts-ci.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .vsts-pr.yml | Sets timeoutInMinutes: 90 for the macOS ARM64 PR job matrix invocation. |
| .vsts-ci.yml | Sets timeoutInMinutes: 90 for the macOS ARM64 CI TestBuild job matrix invocation. |
MichaelSimons
changed the title
Move timeout logic into sdk-build.yml so platforms get appropriate defaults without requiring each caller to specify them: - macOS: 90 minutes (to accommodate slower hosted agents) - All others: 60 minutes - Callers can still override with an explicit timeoutInMinutes parameter Removes now-redundant timeoutInMinutes: 90 overrides from .vsts-pr.yml and .vsts-ci.yml macOS legs. Fixes timeout in build 1466643. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MichaelSimons
force-pushed
the
michaelsimons/increase-mac-timeout-90min
branch
from
June 16, 2026 19:13
27e9c29 to
0267e2d
Compare
Member
Author
|
Gentle ping @dotnet/dotnet-cli for a review. |
baronfel
approved these changes
Jun 17, 2026
Member
Author
|
/ba-g known intermittent test failure tracked with #54817. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes timeout logic in
eng/pipelines/templates/jobs/sdk-build.ymlso that each platform gets an appropriate default timeout without callers needing to specify one explicitly.Motivation: The macOS ARM64 leg timed out at the 60-minute default (build 1466643). Rather than adding yet another per-leg
timeoutInMinutesoverride, this makes the template platform-aware so all macOS legs automatically get the right timeout.Behavior
The template now applies variable defaults based on
parameters.pool.os:Callers can still pass an explicit
timeoutInMinutesparameter to override the defaults.Changes
eng/pipelines/templates/jobs/sdk-build.yml: Replaced hardcoded 60-minute default with conditional logic based onparameters.pool.os.vsts-pr.yml: Removed now-redundanttimeoutInMinutes: 90from macOS x64 CI-only leg.vsts-ci.yml: Removed now-redundanttimeoutInMinutes: 90from macOS x64 official leg