Skip to content

Delete unused resources from CliCommandStrings#53858

Merged
marcpopMSFT merged 1 commit into
mainfrom
copilot/delete-unused-resources-cli-command-strings
May 27, 2026
Merged

Delete unused resources from CliCommandStrings#53858
marcpopMSFT merged 1 commit into
mainfrom
copilot/delete-unused-resources-cli-command-strings

Conversation

Copilot AI commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Removes 15 dead resource entries from CliCommandStrings.resx that have no remaining references in the codebase.

Removed entries

  • CmdPackageDescription
  • VerbRun / VerbTest
  • CouldNotConvertToBoolean / CouldNotConvertToString
  • FailedWithErrorsAndWarnings / FailedWithWarnings
  • InvalidSemVerVersionString
  • ProjectConvertWouldMoveFile / ProjectConvertWouldDeleteFile
  • ToolInstallPackageIdArgumentDescription / ToolInstallPackageIdArgumentName
  • ToolUpdatePackageIdArgumentDescription / ToolUpdatePackageIdArgumentName
  • ValueMustBeAnObject

Corresponding entries removed from all 13 localized .xlf files (cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant).

Copilot AI linked an issue Apr 14, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Remove unused resources from CliCommandStrings Delete unused resources from CliCommandStrings Apr 14, 2026
Copilot AI requested a review from marcpopMSFT April 14, 2026 18:42
@marcpopMSFT marcpopMSFT marked this pull request as ready for review April 17, 2026 18:27
Copilot AI review requested due to automatic review settings April 17, 2026 18:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes dead localized CLI resource entries to keep CliCommandStrings clean and reduce localization surface area.

Changes:

  • Removed 15 unused string resources from CliCommandStrings.resx.
  • Removed the corresponding <trans-unit> entries from all 13 localized .xlf files.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Cli/dotnet/Commands/CliCommandStrings.resx Deletes unused base (en) resource entries.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf Removes corresponding unused Czech translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf Removes corresponding unused German translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.es.xlf Removes corresponding unused Spanish translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.fr.xlf Removes corresponding unused French translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.it.xlf Removes corresponding unused Italian translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.ja.xlf Removes corresponding unused Japanese translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.ko.xlf Removes corresponding unused Korean translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.pl.xlf Removes corresponding unused Polish translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.pt-BR.xlf Removes corresponding unused Portuguese (Brazil) translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.ru.xlf Removes corresponding unused Russian translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.tr.xlf Removes corresponding unused Turkish translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hans.xlf Removes corresponding unused Chinese (Simplified) translation units.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hant.xlf Removes corresponding unused Chinese (Traditional) translation units.

@marcpopMSFT marcpopMSFT force-pushed the copilot/delete-unused-resources-cli-command-strings branch from 7441743 to 6a950d1 Compare May 13, 2026 23:33
@marcpopMSFT marcpopMSFT force-pushed the copilot/delete-unused-resources-cli-command-strings branch from 6a950d1 to 712f689 Compare May 19, 2026 18:51
@marcpopMSFT

Copy link
Copy Markdown
Member

/ba-g unrelated build lock issue.

@marcpopMSFT marcpopMSFT merged commit 9c8db2c into main May 27, 2026
23 of 25 checks passed
@marcpopMSFT marcpopMSFT deleted the copilot/delete-unused-resources-cli-command-strings branch May 27, 2026 18:39
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete unused resources from CliCommandStrings

4 participants