Don't publish assets with Vertical visibility as part of the merged manifest for a vertical.#45553
Merged
Merged
Conversation
…anifest for a vertical.
ghost
added
…ldn't be uploaded from jobs and they won't be in the asset manifest anyway.
jkoritzinsky
force-pushed
the
artifact-visibility-vmr
branch
from
b7a0af1 to
f68a748
Compare
ViktorHofer
approved these changes
Dec 18, 2024
2 tasks
mmitche
reviewed
Dec 19, 2024
| <BinPlaceFile Include="@(ProducedAsset->'$(ArtifactsAssetsDir)%(Identity)')" /> | ||
| <!-- | ||
| When building from source, the Private.SourceBuilt.Artifacts archive already contains the nuget packages. | ||
| Don't binplace any packages or blobs with vertical visibility. These are only used for building other repos within this vertical |
Member
There was a problem hiding this comment.
Suggested change
| Don't binplace any packages or blobs with vertical visibility. These are only used for building other repos within this vertical | |
| In addition, don't binplace any packages or blobs with vertical visibility. These are only used for building other repos within this vertical |
mmitche
reviewed
Dec 19, 2024
| <BinPlaceFile Include="@(ProducedPackage->'$(ArtifactsPackagesDir)%(ShippingFolder)/$(RepositoryName)/%(Identity).%(Version).nupkg')" Condition="'$(DotNetBuildSourceOnly)' != 'true'" /> | ||
| <BinPlaceFile Include="@(ProducedAsset->'$(ArtifactsAssetsDir)%(Identity)')" /> | ||
| <!-- | ||
| When building from source, the Private.SourceBuilt.Artifacts archive already contains the nuget packages. |
Member
There was a problem hiding this comment.
Suggested change
| When building from source, the Private.SourceBuilt.Artifacts archive already contains the nuget packages. | |
| When building from source, the Private.SourceBuilt.Artifacts archive already contains the nuget packages so no need to binplace. |
mmitche
approved these changes
Dec 19, 2024
mmitche
left a comment
mmitche
left a comment
Member
There was a problem hiding this comment.
Approved with minor comments.
ViktorHofer
reviewed
Dec 19, 2024
| { | ||
| string elementId = artifactElement.Attribute(_idAttribute)?.Value | ||
| // Filter out artifacts that are not "External" visibility. | ||
| // Artifacts of "Vertical" visibility should have been filtered out in each individual vertical, |
Member
There was a problem hiding this comment.
Should we assert on that here?
Member
Author
There was a problem hiding this comment.
I'll add some validation
ViktorHofer
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dotnet/arcade#15344
Implements support for Vertical asset visibility in the VMR, where an asset is only visible within a vertical and is not uploaded to AzDO storage nor included in the merged asset manifest for the vertical.