Add mac signing to the other fork of the code path#35167
Merged
Conversation
ghost
added
Member
Author
|
/backport to release/8.0.1xx |
Contributor
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/6089784184 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet/runtime@a3e38ff#diff-43c865d74da4a9b865e6d52bc43aeff8566dc6850b4e23a2786ceefc50b6d3ffL189-L214 caused the first part of the if statement to be hit instead of the second.
There are three parameters that are different in that part of the if. Two relate to windows and we believe won't impact anything but @elinor-fung should review.
The last parameter is a missing macos signing parameter. As such, global tools weren't getting signed on macs and so won't run on M1s (or macs with signing checks enabled)