Skip to content

Test for aot library with eventpipe#34873

Merged
LakshanF merged 4 commits into
dotnet:mainfrom
LakshanF:AddAotLibEventPipeTest
Aug 25, 2023
Merged

Test for aot library with eventpipe#34873
LakshanF merged 4 commits into
dotnet:mainfrom
LakshanF:AddAotLibEventPipeTest

Conversation

@LakshanF

Copy link
Copy Markdown
Contributor

We don't yet support EventPipe in native AOT libraries and this test validates that.

Fixes #34839

@LakshanF LakshanF requested a review from agocke August 23, 2023 15:33
@ghost ghost added Area-NativeAOT Native AOT compilation untriaged Request triage from a team member labels Aug 23, 2023
Comment thread src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs Outdated
Comment thread src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs Outdated
Comment thread src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs Outdated

@agocke agocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs Outdated
@LakshanF LakshanF merged commit d481936 into dotnet:main Aug 25, 2023
@LakshanF LakshanF deleted the AddAotLibEventPipeTest branch August 25, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-NativeAOT Native AOT compilation untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a EventPipe test for a native AOT library

3 participants