Skip to content

Set TransactionScope MaximumTimeout when API is ready #21101

New issue
New issue
Closed
#55595
Closed
Set TransactionScope MaximumTimeout when API is ready#21101
#55595
Assignees
MiYanni
Labels
Area-NetSDK
Milestone
Backlog

Description

@wli3
wli3
opened on Sep 17, 2021

We don't really use TransactionScope sematic to the fullest. The download is not atomic, the "commit" action (the right thing is to use atomic operation like File.Move) is missing. At the same time, TransactionScope has a hard code 10 minutes timeout in dotnet core.

dotnet/runtime#59282 is file for a proper API. Once it is done, we should use the feature instead.

Activity

  1. wli3
    added this to the 6.0.2xx milestone on Sep 17, 2021
  2. ghost added
    Area-NetSDK
    on Sep 17, 2021
  3. ghost added
    untriagedRequest triage from a team member
    on Sep 17, 2021
  4. wli3
    added a commit that references this issue on Sep 17, 2021

    Fix 10 minutes time out of TransactionScope

    0493702
  5. wli3
    changed the title [-]Replace TransactionScope[/-] [+]Set TransactionScope MaximumTimeout when API is ready[/+] on Sep 17, 2021
  6. wli3
    added 2 commits that reference this issue on Sep 17, 2021

    Fix 10 minutes time out of TransactionScope

    9f91479

    Fix 10 minutes time out of TransactionScope

    b888bd0
  7. marcpopMSFT
    modified the milestones: 6.0.2xx, 7.0.1xx on Jan 5, 2022
  8. marcpopMSFT
    modified the milestones: 7.0.1xx, Backlog on Dec 7, 2022
  9. dsplaisted
    removed this from the Backlog milestone on Apr 9, 2025
  10. dsplaisted
    added
    needs team triageRequires a full team discussion
    on Apr 9, 2025

  11. dsplaisted commented on Apr 9, 2025

    @dsplaisted
    dsplaisted
    on Apr 9, 2025
    Member

    The runtime added this API, so I think we could remove our private reflection code:

    sdk/src/Cli/dotnet/TransactionalAction.cs

    Lines 104 to 105 in d2972ed

    SetTransactionManagerField("s_cachedMaxTimeout", true);
    SetTransactionManagerField("s_maximumTimeout", TimeSpan.Zero);

  12. marcpopMSFT
    assigned
    MiYanni
    on Apr 15, 2025
  13. marcpopMSFT
    removed
    untriagedRequest triage from a team member
    needs team triageRequires a full team discussion
    on Apr 15, 2025
  14. marcpopMSFT
    added this to the 10.0.1xx milestone on Apr 15, 2025
  15. marcpopMSFT
    modified the milestones: 10.0.1xx, Backlog on Jul 24, 2026
  16. mthalman
    closed this as completedin #55595on Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-NetSDK

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions