Skip to content

[LoongArch64] Remove the redundant check of DivideByZeroException for GT_UDIV/GT_UMOD in CodeGen::genCodeForDivMod().#99215

Merged
jakobbotsch merged 1 commit intodotnet:mainfrom
LuckyXu-HF:main-LA64
Mar 5, 2024
Merged

[LoongArch64] Remove the redundant check of DivideByZeroException for GT_UDIV/GT_UMOD in CodeGen::genCodeForDivMod().#99215
jakobbotsch merged 1 commit intodotnet:mainfrom
LuckyXu-HF:main-LA64

Conversation

@LuckyXu-HF
Copy link
Contributor

This PR is to optimize the duplicate DivideByZeroException check for GT_UDIV/GT_UMOD in CodeGen::genCodeForDivMod().
This situation is mentioned in PR #98648 for RISC-V.

… GT_UDIV/GT_UMOD in CodeGen::genCodeForDivMod().
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 4, 2024
@ghost
Copy link

ghost commented Mar 4, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is to optimize the duplicate DivideByZeroException check for GT_UDIV/GT_UMOD in CodeGen::genCodeForDivMod().
This situation is mentioned in PR #98648 for RISC-V.

Author: LuckyXu-HF
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@LuckyXu-HF
Copy link
Contributor Author

LuckyXu-HF commented Mar 4, 2024

Hi @clamp03 ,thank you very much for your reminder.
Maybe RISC-V can also remove it.
The above DivideByZeroException check already includes the register situation, so this redundant check can be deleted.

@clamp03
Copy link
Member

clamp03 commented Mar 4, 2024

@LuckyXu-HF Thank you.
@tomeksowi Could you remove it in RISC-V too?

@LuckyXu-HF
Copy link
Contributor Author

@shushanhf @jakobbotsch
Could you please review this PR? Thanks.

@tomeksowi
Copy link
Member

@tomeksowi Could you remove it in RISC-V too?

Done in #99228. Thank you all.

@jakobbotsch
Copy link
Member

@shushanhf Can you approve as well? I'll merge it once you've reviewed.

Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to forget adding Approved.
LGTM
Thanks

@jakobbotsch jakobbotsch merged commit fb700b3 into dotnet:main Mar 5, 2024
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch March 7, 2024 03:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants