Do not compare Span<T> with 'default'#99095
Merged
buyaa-n merged 4 commits intodotnet:mainfrom Mar 1, 2024
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsWhen updating the Do not compare Span To 'null' analyzer to flag comparisons with 'default'. few more warnings found that this PR is trying to fix. Looks comparisons with default is more intentional than comparing with null, mostly used For more context check previous PR: #98958 Learn more form the analyzer proposal
|
stephentoub
reviewed
Feb 29, 2024
src/libraries/Common/src/Microsoft/Win32/SafeHandles/SafeUnicodeStringHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 1, 2024
src/libraries/Common/src/Microsoft/Win32/SafeHandles/SafeUnicodeStringHandle.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography/src/Microsoft/Win32/SafeHandles/SafePasswordHandle.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <stoub@microsoft.com>
vcsjones
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating the Do not compare Span To 'null' analyzer to flag comparisons with 'default'. few more warnings found that this PR is trying to fix. Looks comparisons with default is more intentional than comparing with null, mostly used
Unsafe.IsNullReffor fix, wondering if we should suggest the same for the analyzer.For more context check previous PR: #98958
Learn more form the analyzer proposal