Skip to content

Update the bit field of encoding function names #96082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 5 commits into from
Dec 18, 2023
Merged

Update the bit field of encoding function names #96082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8a1593
Update the bit field of encoding function names
kunalspathak Dec 16, 2023
054839a
Merge remote-tracking branch 'origin/main' into sve-encoding-fn
kunalspathak Dec 16, 2023
8e26da6
Fix merge conflicts
kunalspathak Dec 16, 2023
77feda6
update asserts as per review comments
kunalspathak Dec 18, 2023
1d6fb36
Merge remote-tracking branch 'origin/main' into sve-encoding-fn
kunalspathak Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11616,7 +11616,7 @@ void emitter::emitIns_Call(EmitCallType callType,
{
assert(isVectorRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 31));
return ureg << 0;
}

Expand All @@ -11629,7 +11629,7 @@ void emitter::emitIns_Call(EmitCallType callType,
{
assert(isVectorRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 31));
return ureg << 5;
}

Expand All @@ -11648,28 +11648,28 @@ void emitter::emitIns_Call(EmitCallType callType,

/*****************************************************************************
*
* Return an encoding for the specified 'V' register used in '21' thru '17' position.
* Return an encoding for the specified 'V' register used in '20' thru '16' position.
*/

/*static*/ emitter::code_t emitter::insEncodeReg_V_21_to_17(regNumber reg)
/*static*/ emitter::code_t emitter::insEncodeReg_V_20_to_16(regNumber reg)
{
assert(isVectorRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert((ureg >= 0) && (ureg <= 32));
return ureg << 17;
assert((ureg >= 0) && (ureg <= 31));
return ureg << 16;
}

/*****************************************************************************
*
* Return an encoding for the specified 'R' register used in '21' thru '17' position.
* Return an encoding for the specified 'R' register used in '20' thru '16' position.
*/

/*static*/ emitter::code_t emitter::insEncodeReg_R_21_to_17(regNumber reg)
/*static*/ emitter::code_t emitter::insEncodeReg_R_20_to_16(regNumber reg)
{
assert(isIntegerRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg;
assert((ureg >= 0) && (ureg <= 32));
return ureg << 17;
assert((ureg >= 0) && (ureg <= 31));
return ureg << 16;
}

/*****************************************************************************
Expand All @@ -11681,7 +11681,7 @@ void emitter::emitIns_Call(EmitCallType callType,
{
assert(isIntegerRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 31));
return ureg << 5;
}

Expand All @@ -11694,21 +11694,21 @@ void emitter::emitIns_Call(EmitCallType callType,
{
assert(isIntegerRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 31));
return ureg << 0;
}

/*****************************************************************************
*
* Return an encoding for the specified 'P' register used in '20' thru '17' position.
* Return an encoding for the specified 'P' register used in '19' thru '16' position.
*/

/*static*/ emitter::code_t emitter::insEncodeReg_P_20_to_17(regNumber reg)
/*static*/ emitter::code_t emitter::insEncodeReg_P_19_to_16(regNumber reg)
{
assert(isPredicateRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_P0;
assert((ureg >= 0) && (ureg <= 15));
return ureg << 17;
return ureg << 16;
}

/*****************************************************************************
Expand Down Expand Up @@ -11752,15 +11752,15 @@ void emitter::emitIns_Call(EmitCallType callType,

/*****************************************************************************
*
* Return an encoding for the specified 'R' register used in '18' thru '17' position.
* Return an encoding for the specified 'R' register used in '17' thru '16' position.
*/

/*static*/ emitter::code_t emitter::insEncodeReg_R_18_to_17(regNumber reg)
/*static*/ emitter::code_t emitter::insEncodeReg_R_17_to_16(regNumber reg)
{
assert(isIntegerRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg;
assert((ureg >= 0) && (ureg <= 32));
return ureg << 17;
assert((ureg >= 0) && (ureg <= 31));
return ureg << 16;
}

/*****************************************************************************
Expand Down Expand Up @@ -11814,27 +11814,27 @@ void emitter::emitIns_Call(EmitCallType callType,

/*****************************************************************************
*
* Return an encoding for the specified 'V' register used in '19' thru '17' position.
* Return an encoding for the specified 'V' register used in '18' thru '16' position.
*/

/*static*/ emitter::code_t emitter::insEncodeReg_V_19_to_17(regNumber reg)
/*static*/ emitter::code_t emitter::insEncodeReg_V_18_to_16(regNumber reg)
{
assert(isVectorRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert((ureg >= 0) && (ureg <= 32));
return ureg << 17;
assert((ureg >= 0) && (ureg <= 7));
return ureg << 16;
}

/*****************************************************************************
*
* Return an encoding for the specified 'V' register used in '20' thru '16' position.
* Return an encoding for the specified 'V' register used in '19' thru '16' position.
*/

/*static*/ emitter::code_t emitter::insEncodeReg_V_20_to_16(regNumber reg)
/*static*/ emitter::code_t emitter::insEncodeReg_V_19_to_16(regNumber reg)
{
assert(isVectorRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 15));
return ureg << 16;
}

Expand All @@ -11847,7 +11847,7 @@ void emitter::emitIns_Call(EmitCallType callType,
{
assert(isVectorRegister(reg));
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 31));
return ureg << 6;
}

Expand All @@ -11863,7 +11863,7 @@ void emitter::emitIns_Call(EmitCallType callType,
emitter::code_t ureg = (emitter::code_t)reg - (emitter::code_t)REG_V0;
assert(ureg % 2 == 0);
ureg /= 2u;
assert((ureg >= 0) && (ureg <= 32));
assert((ureg >= 0) && (ureg <= 31));
return ureg << 6;
}

Expand Down
24 changes: 12 additions & 12 deletions src/coreclr/jit/emitarm64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,20 +335,20 @@ static code_t insEncodeReg_V_9_to_5(regNumber reg);
// Return an encoding for the specified 'P' register used in '12' thru '10' position.
static code_t insEncodeReg_P_12_to_10(regNumber reg);

// Return an encoding for the specified 'V' register used in '21' thru '17' position.
static code_t insEncodeReg_V_21_to_17(regNumber reg);
// Return an encoding for the specified 'V' register used in '20' thru '16' position.
static code_t insEncodeReg_V_20_to_16(regNumber reg);

// Return an encoding for the specified 'R' register used in '21' thru '17' position.
static code_t insEncodeReg_R_21_to_17(regNumber reg);
// Return an encoding for the specified 'R' register used in '20' thru '16' position.
static code_t insEncodeReg_R_20_to_16(regNumber reg);

// Return an encoding for the specified 'R' register used in '9' thru '5' position.
static code_t insEncodeReg_R_9_to_5(regNumber reg);

// Return an encoding for the specified 'R' register used in '4' thru '0' position.
static code_t insEncodeReg_R_4_to_0(regNumber reg);

// Return an encoding for the specified 'P' register used in '20' thru '17' position.
static code_t insEncodeReg_P_20_to_17(regNumber reg);
// Return an encoding for the specified 'P' register used in '19' thru '16' position.
static code_t insEncodeReg_P_19_to_16(regNumber reg);

// Return an encoding for the specified 'P' register used in '3' thru '0' position.
static code_t insEncodeReg_P_3_to_0(regNumber reg);
Expand All @@ -359,8 +359,8 @@ static code_t insEncodeReg_P_8_to_5(regNumber reg);
// Return an encoding for the specified 'P' register used in '13' thru '10' position.
static code_t insEncodeReg_P_13_to_10(regNumber reg);

// Return an encoding for the specified 'R' register used in '18' thru '17' position.
static code_t insEncodeReg_R_18_to_17(regNumber reg);
// Return an encoding for the specified 'R' register used in '17' thru '16' position.
static code_t insEncodeReg_R_17_to_16(regNumber reg);

// Return an encoding for the specified 'P' register used in '7' thru '5' position.
static code_t insEncodeReg_P_7_to_5(regNumber reg);
Expand All @@ -374,11 +374,11 @@ static code_t insEncodeReg_P_2_to_0(regNumber reg);
// Return an encoding for the specified predicate type used in '16' position.
static code_t insEncodePredQualifier_16(bool merge);

// Return an encoding for the specified 'V' register used in '19' thru '17' position.
static code_t insEncodeReg_V_19_to_17(regNumber reg);
// Return an encoding for the specified 'V' register used in '18' thru '16' position.
static code_t insEncodeReg_V_18_to_16(regNumber reg);

// Return an encoding for the specified 'V' register used in '20' thru '16' position.
static code_t insEncodeReg_V_20_to_16(regNumber reg);
// Return an encoding for the specified 'V' register used in '19' thru '16' position.
static code_t insEncodeReg_V_19_to_16(regNumber reg);

// Return an encoding for the specified 'V' register used in '9' thru '6' position.
static code_t insEncodeReg_V_9_to_6(regNumber reg);
Expand Down