Fix for a stress crash in ComAwareWeakReferenceNative::HasInteropInfo#94643
Merged
Conversation
…yncblock is gone.
ghost
added
the
Member
Author
The failure on musl appears to be #91757 |
jkotas
approved these changes
Nov 12, 2023
Member
Author
|
Thanks!! |
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6843417160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare cases it is possible for a syncblock to be collected in the time after we detected its presence and before we get into
ComAwareWeakReferenceNative::HasInteropInfo, so we should not assume the syncblock is still there and must null-check before looking inside it.Fixes: #94579