Convert DIV/MOD to UDIV/UMOD using assertions#94347
Merged
EgorBo merged 9 commits intodotnet:mainfrom Nov 6, 2023
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsCloses #94218
|
This was referenced Nov 3, 2023
Member
Author
|
@AndyAyersMS @dotnet/jit-contrib PTAL, diffs are not too big, I think I saw in some places in BCL we explicitly add Also, I remove |
AndyAyersMS
reviewed
Nov 4, 2023
AndyAyersMS
reviewed
Nov 6, 2023
AndyAyersMS
approved these changes
Nov 6, 2023
Member
Author
|
Failure is #86019 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94218
; Method Benchmarks:Test(int):int (FullOpts) cmp ecx, 4 jge SHORT G_M33641_IG05 xor eax, eax ret G_M33641_IG05: mov eax, ecx - sar eax, 31 - and eax, 3 - add eax, ecx - sar eax, 2 + shr eax, 2 ret -; Total bytes of code: 22 +; Total bytes of code: 14