Fix assert about maximum fragment split size#92027
Merged
Merged
Conversation
We want to support arbitrary `DOTNET_JitSplitFunctionSize` values for stressing the unwind fragment splitting logic, but there are limitations to the smallest size that can be split. Thus, we can exceed a specified minimum. Loosen an assert that the last fragment be less than the specified split size, since it might exceed that minimum, e.g., by being a large epilog. Leave the assert specifying the hard requirement of maximum fragment size.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWe want to support arbitrary
|
Contributor
Author
|
@jakobbotsch PTAL |
jakobbotsch
approved these changes
Sep 13, 2023
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to support arbitrary
DOTNET_JitSplitFunctionSizevalues for stressing the unwind fragment splitting logic, but there are limitations to the smallest size that can be split. Thus, we can exceed a specified minimum. Loosen an assert that the last fragment be less than the specified split size, since it might exceed that minimum, e.g., by being a large epilog. Leave the assert specifying the hard requirement of maximum fragment size.Fixes #91251