Skip to content

Start sharing code between ILLink/ILCompiler test infra#91284

Merged
sbomer merged 6 commits into
dotnet:mainfrom
sbomer:illinkShareTestInfra
Aug 30, 2023
Merged

Start sharing code between ILLink/ILCompiler test infra#91284
sbomer merged 6 commits into
dotnet:mainfrom
sbomer:illinkShareTestInfra

Conversation

@sbomer

@sbomer sbomer commented Aug 29, 2023

Copy link
Copy Markdown
Member

This creates a new directory Mono.Linker.Tests.Shared with sources that are shared between the test infra of ILLink/ILCompiler. This starts by sharing most of the code in TestRunner.cs, renaming some types to make the sharing easier.

@sbomer sbomer requested a review from vitek-karas August 29, 2023 17:54
@sbomer sbomer requested a review from marek-safar as a code owner August 29, 2023 17:54
@ghost ghost assigned sbomer Aug 29, 2023
@ghost ghost added the area-ReadyToRun label Aug 29, 2023
@agocke agocke added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed area-ReadyToRun labels Aug 29, 2023
@ghost

ghost commented Aug 29, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

This creates a new directory Mono.Linker.Tests.Shared with sources that are shared between the test infra of ILLink/ILCompiler. This starts by sharing most of the code in TestRunner.cs, renaming some types to make the sharing easier.

Author: sbomer
Assignees: sbomer
Labels:

area-Tools-ILLink

Milestone: -

@agocke agocke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

Comment thread src/coreclr/tools/aot/ILCompiler.Tests/TestCasesRunner/TrimmingArgumentBuilder.cs Outdated
Invalidate options field in Build
@sbomer

sbomer commented Aug 29, 2023

Copy link
Copy Markdown
Member Author

@mrvoorhe PTAL. This is renaming some of the types used in the test infra, so I wanted to run this approach by you.

@mrvoorhe

Copy link
Copy Markdown
Contributor

Thanks. This looks okay.

@sbomer

sbomer commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

Failures are #81911 and #91344.

@vitek-karas vitek-karas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. Only naming comments - suggestions.

Comment thread eng/Subsets.props
Comment thread src/tools/illink/test/Mono.Linker.Tests.Shared/TestRunner.cs
@sbomer

sbomer commented Sep 1, 2023

Copy link
Copy Markdown
Member Author

@vitek-karas I addressed your feedback in #91358. I went with Trimming since that's what I had been using for the shared type names. So ILCompiler.Trimming.Tests, Trimming.Tests.Shared, CustomizeTrimming, etc.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants