Skip to content

ConvertIcuTimeFormatString: convert narrow no-break spaces to spaces too.#83589

Merged
tarekgh merged 3 commits into
dotnet:mainfrom
tmds:timestring_nbsp
Apr 4, 2023
Merged

ConvertIcuTimeFormatString: convert narrow no-break spaces to spaces too.#83589
tarekgh merged 3 commits into
dotnet:mainfrom
tmds:timestring_nbsp

Conversation

@tmds

@tmds tmds commented Mar 17, 2023

Copy link
Copy Markdown
Member

Fixes #83571.

@stephentoub ptal.

@ghost ghost added area-System.Globalization community-contribution Indicates that the PR has been added by a community member labels Mar 17, 2023
@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83571.

@stephentoub ptal.

Author: tmds
Assignees: -
Labels:

area-System.Globalization, community-contribution

Milestone: -

@tarekgh tarekgh added this to the 8.0.0 milestone Mar 17, 2023
@tarekgh

tarekgh commented Mar 17, 2023

Copy link
Copy Markdown
Member

we are discussing the right fix on the issue #83571

@tarekgh tarekgh added needs-author-action An issue or pull request that requires more info or actions from the author. NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Mar 17, 2023
@tmds tmds force-pushed the timestring_nbsp branch from a9c5276 to b321f3b Compare March 28, 2023 11:39
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 28, 2023
@tmds

tmds commented Mar 28, 2023

Copy link
Copy Markdown
Member Author

@tarekgh I've updated the implementation. Can you take a look?
I have not included a test yet, is there a test I can use as a base?

@tarekgh

tarekgh commented Mar 28, 2023

Copy link
Copy Markdown
Member

@tmds the change looks good to me, Thanks. We need to add tests especially parsing date/time strings including several types of spaces. You may look at the file

public static IEnumerable<object[]> Parse_ValidInput_Succeeds_MemberData()
which has different test cases which you can mimic to test parsing. Also, it will be good if you test formatting too (which is the original reported issue).

@tarekgh

tarekgh commented Apr 4, 2023

Copy link
Copy Markdown
Member

@tmds did you have a chance to address the remaining feedback on this PR? Thanks!

@tmds

tmds commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

@tarekgh I've added a test. ptal.

Comment thread src/libraries/System.Runtime/tests/System/DateTimeTests.cs Outdated
@tarekgh

tarekgh commented Apr 4, 2023

Copy link
Copy Markdown
Member

The CI failures are known unrelated issues. I logged #84323 too for the unknown one.

@tarekgh tarekgh merged commit b54d6ef into dotnet:main Apr 4, 2023
@tarekgh

tarekgh commented Apr 4, 2023

Copy link
Copy Markdown
Member

@tmds thanks a lot for the help with this issue.

@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Globalization community-contribution Indicates that the PR has been added by a community member NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Short time format is missing space under en_US on Fedora 38+

2 participants