move fence to the right place#82661
Conversation
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
all gcstress-extra tests succeeded. https://dev.azure.com/dnceng-public/public/_build/results?buildId=184780&view=results I'll run it again. |
|
/azp run runtime-coreclr gcstress-extra |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/gc |
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It's amazing to see gcstress-extra run clean! fwiw, the regularly scheduled run today (without your change) failed again with the same asserts on linux/arm32: https://dev.azure.com/dnceng-public/public/_build/results?buildId=185163&view=ms.vss-test-web.build-test-results-tab |
fixes #82414
we need to make sure the clearing of the syncblock and the increase of the alloc_allocated not reordered. the comment had the right idea but the implementation was incorrect. the fence should be between these 2 operations, not before the 1st one.