Skip to content

move fence to the right place#82661

Merged
jkotas merged 1 commit into
dotnet:mainfrom
Maoni0:nextobj
Feb 26, 2023
Merged

move fence to the right place#82661
jkotas merged 1 commit into
dotnet:mainfrom
Maoni0:nextobj

Conversation

@Maoni0

@Maoni0 Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member

fixes #82414

we need to make sure the clearing of the syncblock and the increase of the alloc_allocated not reordered. the comment had the right idea but the implementation was incorrect. the fence should be between these 2 operations, not before the 1st one.

@ghost ghost assigned Maoni0 Feb 25, 2023
@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr gcstress-extra

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

all gcstress-extra tests succeeded.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=184780&view=results

I'll run it again.

@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr gcstress-extra
/azp run runtime-coreclr gcstress-extra

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr gcstress-extra

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr gcstress-extra

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr gcstress-extra

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ghost

ghost commented Feb 25, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #82414

Author: Maoni0
Assignees: Maoni0
Labels:

area-GC-coreclr

Milestone: -

@Maoni0

Maoni0 commented Feb 25, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr gcstress-extra

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BruceForstall

Copy link
Copy Markdown
Contributor

It's amazing to see gcstress-extra run clean!

fwiw, the regularly scheduled run today (without your change) failed again with the same asserts on linux/arm32: https://dev.azure.com/dnceng-public/public/_build/results?buildId=185163&view=ms.vss-test-web.build-test-results-tab

@jkotas jkotas merged commit 85e85e7 into dotnet:main Feb 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure baseservices/threading/generics/WaitCallback/thread24/thread24.sh

4 participants