JIT: fix SPMI collection for getStaticFieldCurrentClass#75489
Merged
Conversation
This jit interface method has some unusual semantics: the presence of the optional `pIsSpeculative` argument changes its behavior. During collection, SPMI was always passing this parameter, and so was returning incorrect results to the jit. Closes dotnet#74969.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis jit interface method has some unusual semantics: the presence of the optional Closes #74969.
|
Member
Author
|
@EgorBo PTAL Note this means all current SPMI collections are suspect and may give misleading results. Once this is merged, I will trigger a new collection. |
EgorBo
approved these changes
Sep 12, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This jit interface method has some unusual semantics: the presence of the optional
pIsSpeculativeargument changes its behavior. During collection, SPMI was always passing this parameter, and so was returning incorrect results to the jit.Closes #74969.