Skip to content

Fixes for Overlapped tests#73439

Merged
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:overlappedtests
Aug 5, 2022
Merged

Fixes for Overlapped tests#73439
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:overlappedtests

Conversation

@jkotas

@jkotas jkotas commented Aug 5, 2022

Copy link
Copy Markdown
Member
  • Disable test that is testing 64-bit incompatible API on 64-bit platforms
  • Relax ArgumentException argument name validation. The name of the argument that test was expecting did not match the actual name of the method argument since the ArgumentException originates several layers deep into the implementation.

Fixes #73421
Fixes #73422
Fixes mono/mono#15311

@ghost ghost added the area-System.Threading label Aug 5, 2022
@ghost ghost assigned jkotas Aug 5, 2022
- Disable test that is testing 64-bit incompatible API on 64-bit platforms
- Relax ArgumentException argument name validation. The name of the argument that test was expecting did not match the actual name of the method argument since the ArgumentException originates several layers deep into the implementation.

Fixes dotnet#73421
Fixes dotnet#73422
Fixes mono/mono#15311
@ghost

ghost commented Aug 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Disable test that is testing 64-bit incompatible API on 64-bit platforms
  • Relax ArgumentException argument name validation. The name of the argument that test was expecting did not match the actual name of the method argument since the ArgumentException originates several layers deep into the implementation.

Delete argument validation

Fixes #73421
Fixes #73422
Fixes mono/mono#15311

Author: jkotas
Assignees: -
Labels:

area-System.Threading

Milestone: -

@MichalStrehovsky MichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit a0a03e4 into dotnet:main Aug 5, 2022
@jkotas jkotas deleted the overlappedtests branch August 5, 2022 12:52
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

2 participants