Fix annotation on XmlElement constructor parameter

[SteveDunn]

Fixes #71858

[ghost]

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #71858

Author:	SteveDunn
Assignees:	-
Labels:	area-System.Xml
Milestone:	-

[stephentoub]

Thanks!

[ghost]

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

[ericstj]

@stephentoub was the breaking change you were identifying here the change to permit a null string in the virtual methods? @dotnet/area-system-xml can you help submit the document?

[stephentoub]

was the breaking change you were identifying here the change to permit a null string in the virtual methods?

Yes. It's minor, but anyone who was deriving from these types and overriding these methods and who had nullable reference types enabled will now get a compiler warning due to having overrides which say they don't accept nullable when the base virtual now says it does.

(In previous releases, we've had a single breaking change notification that mopped up all of the annotation changes in the release. We might want to do something similar here, if there are others. cc: @jeffhandley)