Redisable timouting MsQuic tests#69843
Merged
Merged
Conversation
ghost
assigned
|
Tagging subscribers to this area: @dotnet/ncl |
Member
Author
|
The timeout occured in #69798 |
Member
|
This seems to fail predictably for me as result of #69603 because we did not pull in new msquic for Windows. |
wfurt
approved these changes
May 26, 2022
wfurt
left a comment
wfurt
left a comment
Member
There was a problem hiding this comment.
LGTM.
I think this is ok for now. We should update msquic and give it another try.
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
I don't think this made it to the preview 5 branch which is seeing build failures on PR builds (for example here #69872). Should this change get cherry-picked to preview 5 branch? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #64944.
The test is still flaky and sometimes causes timeout for the entire test suite.
cc: @wfurt