Skip to content

Fix linux-x86 compilation for clr.alljits subset#68046

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
ta264:linux-x86-clr.alljits-fix
Apr 27, 2022
Merged

Fix linux-x86 compilation for clr.alljits subset#68046
BruceForstall merged 1 commit into
dotnet:mainfrom
ta264:linux-x86-clr.alljits-fix

Conversation

@ta264

@ta264 ta264 commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

Fixes #68044

I don't know if this is the right solution - I haven't tested compiling on windows. Compiling native linux-x64 with this change also seems to work still.

With this fix the resulting product SDK functions, I can create, compile and run a hello world.

@ghost ghost added area-Infrastructure-coreclr Only use for closed issues community-contribution Indicates that the PR has been added by a community member labels Apr 14, 2022
@ghost

ghost commented Apr 14, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68044

I don't know if this is the right solution - I haven't tested compiling on windows. Compiling native linux-x64 with this change also seems to work still.

With this fix the resulting product SDK functions, I can create, compile and run a hello world.

Author: ta264
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@ta264 ta264 mentioned this pull request Apr 14, 2022
Open
@akoeplinger akoeplinger added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Infrastructure-coreclr Only use for closed issues labels Apr 19, 2022
@ghost

ghost commented Apr 19, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68044

I don't know if this is the right solution - I haven't tested compiling on windows. Compiling native linux-x64 with this change also seems to work still.

With this fix the resulting product SDK functions, I can create, compile and run a hello world.

Author: ta264
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

janvorli
janvorli approved these changes Apr 19, 2022
View reviewed changes

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@BruceForstall BruceForstall merged commit 8f7761a into dotnet:main Apr 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clr.alljits subset fails cross-compiling for linux-x86 on linux-x64

4 participants

@ta264 @janvorli @akoeplinger @BruceForstall